Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit da7bc5a

Browse filesBrowse files
kvakilruyadorno
authored andcommitted
doc,worker: deprecate --trace-atomics-wait
V8 has asked if it possible to remove the functionality underlying `--trace-atomics-wait`. Let's start with a documentation-only deprecation. PR-URL: #44093 Refs: #42982 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Feng Yu <F3n67u@outlook.com>
1 parent 8ed3939 commit da7bc5a
Copy full SHA for da7bc5a

File tree

Expand file treeCollapse file tree

4 files changed

+19
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

4 files changed

+19
-1
lines changed
Open diff view settings
Collapse file

‎doc/api/cli.md‎

Copy file name to clipboardExpand all lines: doc/api/cli.md
+3Lines changed: 3 additions & 0 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -1217,8 +1217,11 @@ for TLSv1.2, which is not as secure as TLSv1.3.
12171217

12181218
<!-- YAML
12191219
added: v14.3.0
1220+
deprecated: REPLACEME
12201221
-->
12211222

1223+
> Stability: 0 - Deprecated
1224+
12221225
Print short summaries of calls to [`Atomics.wait()`][] to stderr.
12231226
The output could look like this:
12241227

Collapse file

‎doc/api/deprecations.md‎

Copy file name to clipboardExpand all lines: doc/api/deprecations.md
+14Lines changed: 14 additions & 0 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -3169,13 +3169,27 @@ Type: Documentation-only
31693169
`code` values other than `undefined`, `null`, integer numbers and integer
31703170
strings (e.g., '1') are deprecated as parameter in [`process.exit()`][].
31713171

3172+
### DEP0165: `--trace-atomics-wait`
3173+
3174+
<!-- YAML
3175+
changes:
3176+
- version: REPLACEME
3177+
pr-url: https://github.com/nodejs/node/pull/44093
3178+
description: Documentation-only deprecation.
3179+
-->
3180+
3181+
Type: Documentation-only
3182+
3183+
The [`--trace-atomics-wait`][] flag is deprecated.
3184+
31723185
[Legacy URL API]: url.md#legacy-url-api
31733186
[NIST SP 800-38D]: https://nvlpubs.nist.gov/nistpubs/Legacy/SP/nistspecialpublication800-38d.pdf
31743187
[RFC 6066]: https://tools.ietf.org/html/rfc6066#section-3
31753188
[WHATWG URL API]: url.md#the-whatwg-url-api
31763189
[`"exports"` or `"main"` entry]: packages.md#main-entry-point-export
31773190
[`--pending-deprecation`]: cli.md#--pending-deprecation
31783191
[`--throw-deprecation`]: cli.md#--throw-deprecation
3192+
[`--trace-atomics-wait`]: cli.md#--trace-atomics-wait
31793193
[`--unhandled-rejections`]: cli.md#--unhandled-rejectionsmode
31803194
[`Buffer.allocUnsafeSlow(size)`]: buffer.md#static-method-bufferallocunsafeslowsize
31813195
[`Buffer.from(array)`]: buffer.md#static-method-bufferfromarray
Collapse file

‎doc/node.1‎

Copy file name to clipboardExpand all lines: doc/node.1
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -432,6 +432,7 @@ favour of TLSv1.3, which is more secure.
432432
Print short summaries of calls to
433433
.Sy Atomics.wait() .
434434
.
435+
This flag is deprecated.
435436
.It Fl -trace-deprecation
436437
Print stack traces for deprecations.
437438
.
Collapse file

‎src/node_options.cc‎

Copy file name to clipboardExpand all lines: src/node_options.cc
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -540,7 +540,7 @@ EnvironmentOptionsParser::EnvironmentOptionsParser() {
540540
&EnvironmentOptions::throw_deprecation,
541541
kAllowedInEnvironment);
542542
AddOption("--trace-atomics-wait",
543-
"trace Atomics.wait() operations",
543+
"(deprecated) trace Atomics.wait() operations",
544544
&EnvironmentOptions::trace_atomics_wait,
545545
kAllowedInEnvironment);
546546
AddOption("--trace-deprecation",

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.