Commit d96a97a
module: make synthetic module evaluation steps return a Promise to support top level await
Top level await expects that all module script evaluation returns a
Promise. As such, update
ModuleWrap::SyntheticModuleEvaluationStepsCallback to return a
resolved Promise now that V8 has enabled top-level await by default.
Unfortunately I don't have a spec reference that I can point to here
because the Built-in modules proposal isn't yet updated for
top level await.
The corresponding change for Blink is
https://chromium-review.googlesource.com/c/chromium/src/+/2568823.
This will allow a workaround for Node in this V8 bugfix to be removed:
https://chromium-review.googlesource.com/c/v8/v8/+/2673794.
Fixes: #37299
PR-URL: #37300
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michaël Zasso <targos@protonmail.com>1 parent 7d8fd3f commit d96a97aCopy full SHA for d96a97a
File tree
Expand file treeCollapse file tree
1 file changed
+8
-1
lines changedOpen diff view settings
Filter options
- src
Expand file treeCollapse file tree
1 file changed
+8
-1
lines changedOpen diff view settings
Collapse file
+8-1Lines changed: 8 additions & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
665 | 665 | |
666 | 666 | |
667 | 667 | |
668 | | - |
| 668 | + |
| 669 | + |
| 670 | + |
| 671 | + |
| 672 | + |
| 673 | + |
| 674 | + |
| 675 | + |
669 | 676 | |
670 | 677 | |
671 | 678 | |
|
0 commit comments