Commit d938e85
n-api: add more property defaults
Add a default value for class method and js like property in enum
napi_property_attributes.
n-api currently offers only one default which is non configurable,
non writable, non enumerable - like Object.defineProperty(). While
this is formal correct the usual way to create properties in JS is
either by defining a class or use obj.prop = value.
The defaults from these variants are now backed into enum values.
PR-URL: #35214
Refs: nodejs/node-addon-api#811
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>1 parent c3e1bf7 commit d938e85Copy full SHA for d938e85
File tree
Expand file treeCollapse file tree
2 files changed
+28
-0
lines changedOpen diff view settings
Filter options
- doc/api
- src
Expand file treeCollapse file tree
2 files changed
+28
-0
lines changedOpen diff view settings
Collapse file
+18Lines changed: 18 additions & 0 deletions
- Display the source diff
- Display the rich diff
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
3643 | 3643 | |
3644 | 3644 | |
3645 | 3645 | |
| 3646 | + |
| 3647 | + |
| 3648 | + |
| 3649 | + |
| 3650 | + |
| 3651 | + |
3646 | 3652 | |
3647 | 3653 | |
3648 | 3654 | |
| ||
3654 | 3660 | |
3655 | 3661 | |
3656 | 3662 | |
| 3663 | + |
| 3664 | + |
| 3665 | + |
| 3666 | + |
| 3667 | + |
| 3668 | + |
| 3669 | + |
| 3670 | + |
3657 | 3671 | |
3658 | 3672 | |
3659 | 3673 | |
| ||
3672 | 3686 | |
3673 | 3687 | |
3674 | 3688 | |
| 3689 | + |
| 3690 | + |
| 3691 | + |
| 3692 | + |
3675 | 3693 | |
3676 | 3694 | |
3677 | 3695 | |
|
Collapse file
+10Lines changed: 10 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
30 | 30 | |
31 | 31 | |
32 | 32 | |
| 33 | + |
| 34 | + |
| 35 | + |
| 36 | + |
| 37 | + |
| 38 | + |
| 39 | + |
| 40 | + |
| 41 | + |
| 42 | + |
33 | 43 | |
34 | 44 | |
35 | 45 | |
|
0 commit comments