Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit d8ba2c0

Browse filesBrowse files
santigimenojasnell
authored andcommitted
test: fix http-upgrade-client flakiness
It's not guaranteed that the socket data is received in the same chunk as the upgrade response. Listen for the `data` event to make sure all the data is received. PR-URL: #4602 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 6018fa1 commit d8ba2c0
Copy full SHA for d8ba2c0

File tree

Expand file treeCollapse file tree

1 file changed

+8
-3
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+8
-3
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-http-upgrade-client.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-http-upgrade-client.js
+8-3Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,14 @@ srv.listen(common.PORT, '127.0.0.1', function() {
4040
}
4141
});
4242
req.on('upgrade', function(res, socket, upgradeHead) {
43-
// XXX: This test isn't fantastic, as it assumes that the entire response
44-
// from the server will arrive in a single data callback
45-
assert.equal(upgradeHead, 'nurtzo');
43+
var recvData = upgradeHead;
44+
socket.on('data', function(d) {
45+
recvData += d;
46+
});
47+
48+
socket.on('close', common.mustCall(function() {
49+
assert.equal(recvData, 'nurtzo');
50+
}));
4651

4752
console.log(res.headers);
4853
var expectedHeaders = {'hello': 'world',

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.