Commit d89f310
committed
module: enable dynamic import flag for esmodules
currently if you want to use dynamic import you must use both the
`--experimental-modules` and the `--harmony-dynamic-imports` flags.
Chrome is currently shipping dynamic import unflagged, the flag
only remains in V8 to guard embedders who have not set the appropriate
callback from throwing an unhandled rejection when the feature is used.
As such it is reasonable to enable the flag by default for
`--experimental-modules`
Backport-PR-URL: #17823
PR-URL: #18387
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>1 parent 00d5422 commit d89f310Copy full SHA for d89f310
File tree
Expand file treeCollapse file tree
3 files changed
+5
-3
lines changedOpen diff view settings
Filter options
- doc/api
- src
- test/es-module
Expand file treeCollapse file tree
3 files changed
+5
-3
lines changedOpen diff view settings
Collapse file
+2-2Lines changed: 2 additions & 2 deletions
- Display the source diff
- Display the rich diff
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
33 | 33 | |
34 | 34 | |
35 | 35 | |
36 | | - |
37 | | - |
| 36 | + |
| 37 | + |
38 | 38 | |
39 | 39 | |
40 | 40 | |
|
Collapse file
+2Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
4077 | 4077 | |
4078 | 4078 | |
4079 | 4079 | |
| 4080 | + |
| 4081 | + |
4080 | 4082 | |
4081 | 4083 | |
4082 | 4084 | |
|
Collapse file
test/es-module/test-esm-dynamic-import.js
Copy file name to clipboardExpand all lines: test/es-module/test-esm-dynamic-import.js+1-1Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
1 | | - |
| 1 | + |
2 | 2 | |
3 | 3 | |
4 | 4 | |
|
0 commit comments