Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit d83d89a

Browse filesBrowse files
mhdawsonaduh95
authored andcommitted
crypto: add missing return value check
Add return value check for call to SSL_CTX_add_client_CA to be consistent with other places it is called Fixed unused warning in one of the static analysis tools we use at Red Hat even though it is not being reported by coverity in the configuration we run. Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: #56615 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent bcc1c65 commit d83d89a
Copy full SHA for d83d89a

File tree

Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Collapse file

‎src/crypto/crypto_context.cc‎

Copy file name to clipboardExpand all lines: src/crypto/crypto_context.cc
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1164,7 +1164,7 @@ void SecureContext::LoadPKCS12(const FunctionCallbackInfo<Value>& args) {
11641164
X509* ca = sk_X509_value(extra_certs.get(), i);
11651165

11661166
X509_STORE_add_cert(sc->GetCertStoreOwnedByThisSecureContext(), ca);
1167-
SSL_CTX_add_client_CA(sc->ctx_.get(), ca);
1167+
CHECK_EQ(1, SSL_CTX_add_client_CA(sc->ctx_.get(), ca));
11681168
}
11691169
ret = true;
11701170

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.