Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit d795d93

Browse filesBrowse files
vmorozruyadorno
authored andcommitted
build: fix MSVC 2022 Release compilation
PR-URL: #46228 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
1 parent 813b160 commit d795d93
Copy full SHA for d795d93

File tree

Expand file treeCollapse file tree

4 files changed

+20
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

4 files changed

+20
-2
lines changed
Open diff view settings
Collapse file

‎.github/workflows/build-windows.yml‎

Copy file name to clipboardExpand all lines: .github/workflows/build-windows.yml
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ jobs:
3434
if: github.event.pull_request.draft == false
3535
strategy:
3636
matrix:
37-
windows: [windows-2019]
37+
windows: [windows-2019, windows-2022]
3838
fail-fast: false
3939
runs-on: ${{ matrix.windows }}
4040
steps:
Collapse file

‎.github/workflows/coverage-windows.yml‎

Copy file name to clipboardExpand all lines: .github/workflows/coverage-windows.yml
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ permissions:
3737
jobs:
3838
coverage-windows:
3939
if: github.event.pull_request.draft == false
40-
runs-on: windows-2019
40+
runs-on: windows-2022
4141
steps:
4242
- uses: actions/checkout@v3
4343
with:
Collapse file
+10Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
<?xml version="1.0" encoding="utf-8"?>
2+
<Project>
3+
<ItemDefinitionGroup>
4+
<MARMASM>
5+
<!-- Works around a situation when we preprocess file in $(IntDir). In such case the output file is the same as input file
6+
and we get access violation. Appending '.pp' file extension to the output file name resolves this issue. -->
7+
<PreprocessedFileName Condition="'%(PreprocessedFileName)' == ''">$(IntDir)%(FileName)%(Extension).pp</PreprocessedFileName>
8+
</MARMASM>
9+
</ItemDefinitionGroup>
10+
</Project>
Collapse file

‎tools/v8_gypfiles/v8.gyp‎

Copy file name to clipboardExpand all lines: tools/v8_gypfiles/v8.gyp
+8Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1433,6 +1433,14 @@
14331433
['want_separate_host_toolset', {
14341434
'toolsets': ['host'],
14351435
}],
1436+
['OS=="win"', {
1437+
'msvs_precompiled_header': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.h',
1438+
'msvs_precompiled_source': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.cc',
1439+
'sources': [
1440+
'<(_msvs_precompiled_header)',
1441+
'<(_msvs_precompiled_source)',
1442+
],
1443+
}],
14361444
],
14371445
}, # mksnapshot
14381446
{

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.