Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit d795301

Browse filesBrowse files
TrottMyles Borins
Trott
authored and
Myles Borins
committed
test: remove unnecessary assignments
common.js needs to be loaded in all tests so that there is checking for variable leaks and possibly other things. However, it does not need to be assigned to a variable if nothing in common.js is referred to elsewhere in the test. The main tradeoff for this bit of code churn is that it gets the code base most of the way to being able to enable the no-unused-vars rule in eslint. (The non-tooling benefit is that it lessens cognitive load when reading tests as it is an immediate indication that none of the functions or properties in common.js will be used by the test.) PR-URL: #4563 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
1 parent 41882e4 commit d795301
Copy full SHA for d795301

File tree

Expand file treeCollapse file tree

307 files changed

+316
-317
lines changed
Open diff view settings
Filter options

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Dismiss banner
Expand file treeCollapse file tree

307 files changed

+316
-317
lines changed
Open diff view settings
Collapse file

‎test/internet/test-dns-txt-sigsegv.js‎

Copy file name to clipboardExpand all lines: test/internet/test-dns-txt-sigsegv.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
'use strict';
2-
var common = require('../common');
2+
require('../common');
33
var assert = require('assert');
44
var dns = require('dns');
55

Collapse file

‎test/internet/test-dns.js‎

Copy file name to clipboardExpand all lines: test/internet/test-dns.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
'use strict';
2-
var common = require('../common');
2+
require('../common');
33
var assert = require('assert'),
44
dns = require('dns'),
55
net = require('net'),
Collapse file

‎test/internet/test-http-dns-fail.js‎

Copy file name to clipboardExpand all lines: test/internet/test-http-dns-fail.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* should trigger the error event after each attempt.
55
*/
66

7-
var common = require('../common');
7+
require('../common');
88
var assert = require('assert');
99
var http = require('http');
1010

Collapse file

‎test/internet/test-net-connect-timeout.js‎

Copy file name to clipboardExpand all lines: test/internet/test-net-connect-timeout.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
// https://groups.google.com/forum/#!topic/nodejs/UE0ZbfLt6t8
44
// https://groups.google.com/forum/#!topic/nodejs-dev/jR7-5UDqXkw
55

6-
var common = require('../common');
6+
require('../common');
77
var net = require('net');
88
var assert = require('assert');
99

Collapse file

‎test/internet/test-net-connect-unref.js‎

Copy file name to clipboardExpand all lines: test/internet/test-net-connect-unref.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
'use strict';
2-
var common = require('../common');
2+
require('../common');
33
var assert = require('assert');
44
var net = require('net');
55

Collapse file

‎test/message/2100bytes.js‎

Copy file name to clipboardExpand all lines: test/message/2100bytes.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
'use strict';
2-
var common = require('../common');
2+
require('../common');
33
var assert = require('assert');
44
var util = require('util');
55

Collapse file

‎test/message/core_line_numbers.js‎

Copy file name to clipboardExpand all lines: test/message/core_line_numbers.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
'use strict';
2-
const common = require('../common');
2+
require('../common');
33
const punycode = require('punycode');
44

55
// This test verifies that line numbers in core modules are reported correctly.
Collapse file

‎test/message/error_exit.js‎

Copy file name to clipboardExpand all lines: test/message/error_exit.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
'use strict';
2-
var common = require('../common');
2+
require('../common');
33
var assert = require('assert');
44

55
process.on('exit', function(code) {
Collapse file

‎test/message/eval_messages.js‎

Copy file name to clipboardExpand all lines: test/message/eval_messages.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
'use strict';
22

3-
var common = require('../common');
3+
require('../common');
44
var assert = require('assert');
55

66
var spawn = require('child_process').spawn;
Collapse file

‎test/message/hello_world.js‎

Copy file name to clipboard
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
'use strict';
2-
var common = require('../common');
2+
require('../common');
33
var assert = require('assert');
44

55
console.log('hello world');

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.