Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit d641164

Browse filesBrowse files
TrottItalo A. Casas
Trott
authored and
Italo A. Casas
committed
doc: update pull request template URL layout
Putting the link for the commit guideline at the bottom of the pull request template makes it a bit confusing when opening a pull request as the markdown does not render. Not everyone is familiar with the syntax used there and it is easy to mess it up (for example, by not leaving a blank line above it). It is more natural and useful if the URL is included inline. PR-URL: #12216 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent 6feea08 commit d641164
Copy full SHA for d641164

File tree

Expand file treeCollapse file tree

1 file changed

+1
-3
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-3
lines changed
Open diff view settings
Collapse file

‎.github/PULL_REQUEST_TEMPLATE.md‎

Copy file name to clipboardExpand all lines: .github/PULL_REQUEST_TEMPLATE.md
+1-3Lines changed: 1 addition & 3 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,7 @@ Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md
1313
- [ ] `make -j4 test` (UNIX), or `vcbuild test nosign` (Windows) passes
1414
- [ ] tests and/or benchmarks are included
1515
- [ ] documentation is changed or added
16-
- [ ] commit message follows [commit guidelines][]
16+
- [ ] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-guidelines)
1717

1818
##### Affected core subsystem(s)
1919
<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->
20-
21-
[commit guidelines]: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-guidelines

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.