Commit d615757
test: fix flaky test-net-socket-local-address
Prior to this commit, the test was flaky because it was
executing the majority of its logic in a function called from
the client and multiple events on the server. This commit
simplifies the test by separating the server's connection and
listening events, and isolating the client logic.
Refs: #4476
Refs: #4644
PR-URL: #4650
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>1 parent 40c8e6d commit d615757Copy full SHA for d615757
File tree
Expand file treeCollapse file tree
1 file changed
+13
-19
lines changedOpen diff view settings
Filter options
- test/parallel
Expand file treeCollapse file tree
1 file changed
+13
-19
lines changedOpen diff view settings
Collapse file
test/parallel/test-net-socket-local-address.js
Copy file name to clipboardExpand all lines: test/parallel/test-net-socket-local-address.js+13-19Lines changed: 13 additions & 19 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
12 | 12 | |
13 | 13 | |
14 | 14 | |
15 | | - |
16 | | - |
| 15 | + |
| 16 | + |
17 | 17 | |
18 | | - |
| 18 | + |
19 | 19 | |
20 | 20 | |
21 | | - |
22 | | - |
23 | | - |
| 21 | + |
24 | 22 | |
25 | 23 | |
26 | | - |
| 24 | + |
27 | 25 | |
28 | 26 | |
29 | | - |
| 27 | + |
30 | 28 | |
31 | | - |
32 | | - |
33 | | - |
| 29 | + |
| 30 | + |
| 31 | + |
34 | 32 | |
35 | 33 | |
36 | 34 | |
37 | | - |
38 | | - |
39 | | - |
40 | | - |
41 | | - |
42 | | - |
43 | | - |
44 | | - |
45 | 35 | |
| 36 | + |
| 37 | + |
| 38 | + |
| 39 | + |
46 | 40 | |
0 commit comments