Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit d5fc823

Browse filesBrowse files
committed
test_runner: hide failing tests title when all tests pass
PR-URL: #47370 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 1d453e4 commit d5fc823
Copy full SHA for d5fc823

File tree

Expand file treeCollapse file tree

3 files changed

+19
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

3 files changed

+19
-0
lines changed
Open diff view settings
Collapse file

‎lib/internal/test_runner/reporter/spec.js‎

Copy file name to clipboardExpand all lines: lib/internal/test_runner/reporter/spec.js
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,10 @@ class SpecReporter extends Transform {
124124
callback(null, this.#handleEvent({ type, data }));
125125
}
126126
_flush(callback) {
127+
if (this.#failedTests.length === 0) {
128+
callback(null, '');
129+
return;
130+
}
127131
const results = [`\n${colors['test:fail']}${symbols['test:fail']}failing tests:${white}\n`];
128132
for (let i = 0; i < this.#failedTests.length; i++) {
129133
ArrayPrototypePush(results, this.#formatTestReport(
Collapse file
+6Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
// Flags: --no-warnings --test-reporter=spec
2+
'use strict';
3+
require('../common');
4+
const { it } = require('node:test');
5+
6+
it('should pass', () => {});
Collapse file
+9Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
* should pass *(*ms)*
2+
*tests 1*
3+
*suites 0*
4+
*pass 1*
5+
*fail 0*
6+
*cancelled 0*
7+
*skipped 0*
8+
*todo 0*
9+
*duration_ms *

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.