Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit d5d64c3

Browse filesBrowse files
geekrvagg
authored andcommitted
collaborator_guide: clarify commit message rules
Italicize the full URL being required in metadata. PR-URL: #5661 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James Snell <jasnell@gmail.com>
1 parent 2a442b3 commit d5d64c3
Copy full SHA for d5d64c3

File tree

Expand file treeCollapse file tree

1 file changed

+5
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+5
-2
lines changed
Open diff view settings
Collapse file

‎COLLABORATOR_GUIDE.md‎

Copy file name to clipboardExpand all lines: COLLABORATOR_GUIDE.md
+5-2Lines changed: 5 additions & 2 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -93,14 +93,17 @@ information regarding the change process:
9393

9494
- A `Reviewed-By: Name <email>` line for yourself and any
9595
other Collaborators who have reviewed the change.
96-
- A `PR-URL:` line that references the full GitHub URL of the original
96+
- A `PR-URL:` line that references the *full* GitHub URL of the original
9797
pull request being merged so it's easy to trace a commit back to the
9898
conversation that led up to that change.
99-
- A `Fixes: X` line, where _X_ is either includes the full GitHub URL
99+
- A `Fixes: X` line, where _X_ either includes the *full* GitHub URL
100100
for an issue, and/or the hash and commit message if the commit fixes
101101
a bug in a previous commit. Multiple `Fixes:` lines may be added if
102102
appropriate.
103103

104+
Review the commit message to ensure that it adheres to the guidelines
105+
outlined in the [contributing](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit) guide.
106+
104107
See the commit log for examples such as
105108
[this one](https://github.com/nodejs/node/commit/b636ba8186) if unsure
106109
exactly how to format your commit messages.

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.