Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit d597b8e

Browse filesBrowse files
vmorozaduh95
authored andcommitted
build,tools: fix addon build deadlock on errors
PR-URL: #61321 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent 320b576 commit d597b8e
Copy full SHA for d597b8e

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎tools/build_addons.py‎

Copy file name to clipboardExpand all lines: tools/build_addons.py
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,8 @@ def node_gyp_rebuild(test_dir):
5858

5959
# We buffer the output and print it out once the process is done in order
6060
# to avoid interleaved output from multiple builds running at once.
61-
return_code = process.wait()
6261
stdout, stderr = process.communicate()
62+
return_code = process.returncode
6363
if return_code != 0:
6464
print(f'Failed to build addon in {test_dir}:')
6565
if stdout:

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.