Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit d54432f

Browse filesBrowse files
committed
src: keep object alive in stream_pipe code
This was overlooked in a489583. Refs: #30374 PR-URL: #30666 Fixes: #30643 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 9d8d2e1 commit d54432f
Copy full SHA for d54432f

File tree

Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Collapse file

‎src/stream_pipe.cc‎

Copy file name to clipboardExpand all lines: src/stream_pipe.cc
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ void StreamPipe::Unpipe() {
7272
// inside the garbage collector, so we can’t run JS here.
7373
HandleScope handle_scope(env()->isolate());
7474
BaseObjectPtr<StreamPipe> strong_ref{this};
75-
env()->SetImmediate([this](Environment* env) {
75+
env()->SetImmediate([this, strong_ref](Environment* env) {
7676
HandleScope handle_scope(env->isolate());
7777
Context::Scope context_scope(env->context());
7878
Local<Object> object = this->object();

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.