Commit d523eb9
committed
tls: use emitWarning() for dhparam < 2048 bits
When a dhparam less than 2048 bits was used, a warning was being
printed directly to console.error using an internalUtil.trace
function that was not used anywhere else. This replaces it with
a proper process warning and removes the internalUtil.trace
function.
PR-URL: #11447
Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rod Vagg <rod@vagg.org>1 parent 0510472 commit d523eb9Copy full SHA for d523eb9
File tree
Expand file treeCollapse file tree
4 files changed
+6
-8
lines changedOpen diff view settings
Filter options
- lib
- internal
- src
- test/parallel
Expand file treeCollapse file tree
4 files changed
+6
-8
lines changedOpen diff view settings
Collapse file
+1-2Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
1 | 1 | |
2 | 2 | |
3 | | - |
4 | 3 | |
5 | 4 | |
6 | 5 | |
| ||
99 | 98 | |
100 | 99 | |
101 | 100 | |
102 | | - |
| 101 | + |
103 | 102 | |
104 | 103 | |
105 | 104 | |
|
Collapse file
-5Lines changed: 0 additions & 5 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
1 | 1 | |
2 | 2 | |
3 | 3 | |
4 | | - |
5 | 4 | |
6 | 5 | |
7 | 6 | |
| ||
10 | 9 | |
11 | 10 | |
12 | 11 | |
13 | | - |
14 | | - |
15 | | - |
16 | | - |
17 | 12 | |
18 | 13 | |
19 | 14 | |
|
Collapse file
+1-1Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
933 | 933 | |
934 | 934 | |
935 | 935 | |
936 | | - |
| 936 | + |
937 | 937 | |
938 | 938 | |
939 | 939 | |
|
Collapse file
test/parallel/test-tls-dhe.js
Copy file name to clipboardExpand all lines: test/parallel/test-tls-dhe.js+4Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
| 1 | + |
1 | 2 | |
2 | 3 | |
3 | 4 | |
| ||
22 | 23 | |
23 | 24 | |
24 | 25 | |
| 26 | + |
| 27 | + |
| 28 | + |
25 | 29 | |
26 | 30 | |
27 | 31 | |
|
0 commit comments