Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit d4e4207

Browse filesBrowse files
fhinkelgibfahn
authored andcommitted
src: use std::unique_ptr in base-object-inl.h
Drive-by fix: delete superflouos nullptr in ptr.reset(). PR-URL: #17079 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com>
1 parent 333537a commit d4e4207
Copy full SHA for d4e4207

File tree

Expand file treeCollapse file tree

2 files changed

+2
-3
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+2
-3
lines changed
Open diff view settings
Collapse file

‎src/base-object-inl.h‎

Copy file name to clipboardExpand all lines: src/base-object-inl.h
+1-2Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,8 @@ inline Environment* BaseObject::env() const {
6565
template <typename Type>
6666
inline void BaseObject::WeakCallback(
6767
const v8::WeakCallbackInfo<Type>& data) {
68-
Type* self = data.GetParameter();
68+
std::unique_ptr<Type> self(data.GetParameter());
6969
self->persistent().Reset();
70-
delete self;
7170
}
7271

7372

Collapse file

‎src/env-inl.h‎

Copy file name to clipboardExpand all lines: src/env-inl.h
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -349,7 +349,7 @@ inline Environment::~Environment() {
349349
#if HAVE_INSPECTOR
350350
// Destroy inspector agent before erasing the context. The inspector
351351
// destructor depends on the context still being accessible.
352-
inspector_agent_.reset(nullptr);
352+
inspector_agent_.reset();
353353
#endif
354354

355355
context()->SetAlignedPointerInEmbedderData(kContextEmbedderDataIndex,

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.