Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit d497f26

Browse filesBrowse files
gengjiawenMylesBorins
authored andcommitted
src: refactor to more safe method
PR-URL: #32087 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 2262e7c commit d497f26
Copy full SHA for d497f26

File tree

Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed
Open diff view settings
Collapse file

‎src/module_wrap.cc‎

Copy file name to clipboardExpand all lines: src/module_wrap.cc
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1460,8 +1460,8 @@ static MaybeLocal<Promise> ImportModuleDynamically(
14601460

14611461
Local<PrimitiveArray> options = referrer->GetHostDefinedOptions();
14621462
if (options->Length() != HostDefinedOptions::kLength) {
1463-
Local<Promise::Resolver> resolver =
1464-
Promise::Resolver::New(context).ToLocalChecked();
1463+
Local<Promise::Resolver> resolver;
1464+
if (!Promise::Resolver::New(context).ToLocal(&resolver)) return {};
14651465
resolver
14661466
->Reject(context,
14671467
v8::Exception::TypeError(FIXED_ONE_BYTE_STRING(

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.