Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit d48e00e

Browse filesBrowse files
Trottdanielleadams
authored andcommitted
test: fix test-memory-usage.js for IBMi
Newly added process.memoryUsage.rss() will presumably return 0 on IBMi the same way process.memoryUsage().rss does. Allow IBMi to skip the new assertion. The test was using a mix of `assert()` and `assert.ok()`. This change makes it consistently use `assert.ok()`. PR-URL: #36758 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
1 parent b2c1aeb commit d48e00e
Copy full SHA for d48e00e

File tree

Expand file treeCollapse file tree

1 file changed

+6
-5
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+6
-5
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-memory-usage.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-memory-usage.js
+6-5Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,11 @@ const assert = require('assert');
2626

2727
const r = process.memoryUsage();
2828
// On IBMi, the rss memory always returns zero
29-
if (!common.isIBMi)
29+
if (!common.isIBMi) {
3030
assert.ok(r.rss > 0);
31+
assert.ok(process.memoryUsage.rss() > 0);
32+
}
33+
3134
assert.ok(r.heapTotal > 0);
3235
assert.ok(r.heapUsed > 0);
3336
assert.ok(r.external > 0);
@@ -39,10 +42,8 @@ if (r.arrayBuffers > 0) {
3942
const ab = new ArrayBuffer(size);
4043

4144
const after = process.memoryUsage();
42-
assert(after.external - r.external >= size,
43-
`${after.external} - ${r.external} >= ${size}`);
45+
assert.ok(after.external - r.external >= size,
46+
`${after.external} - ${r.external} >= ${size}`);
4447
assert.strictEqual(after.arrayBuffers - r.arrayBuffers, size,
4548
`${after.arrayBuffers} - ${r.arrayBuffers} === ${size}`);
4649
}
47-
48-
assert(process.memoryUsage.rss() > 0);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.