Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit d4873bc

Browse filesBrowse files
anonrigtargos
authored andcommitted
lib: remove lib/internal/idna.js
PR-URL: #55050 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
1 parent d3f8c35 commit d4873bc
Copy full SHA for d4873bc

File tree

Expand file treeCollapse file tree

3 files changed

+1
-6
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

3 files changed

+1
-6
lines changed
Open diff view settings
Collapse file

‎lib/internal/idna.js‎

Copy file name to clipboardExpand all lines: lib/internal/idna.js
-4Lines changed: 0 additions & 4 deletions
This file was deleted.
Collapse file

‎lib/url.js‎

Copy file name to clipboardExpand all lines: lib/url.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ const {
3030
decodeURIComponent,
3131
} = primordials;
3232

33-
const { toASCII } = require('internal/idna');
33+
const { toASCII } = internalBinding('encoding_binding');
3434
const { encodeStr, hexTable } = require('internal/querystring');
3535
const querystring = require('querystring');
3636

Collapse file

‎test/parallel/test-bootstrap-modules.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-bootstrap-modules.js
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,6 @@ expected.atRunTime = new Set([
117117

118118
if (common.isMainThread) {
119119
[
120-
'NativeModule internal/idna',
121120
'NativeModule url',
122121
].forEach(expected.beforePreExec.add.bind(expected.beforePreExec));
123122
} else { // Worker.

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.