Commit d44540f
buffer: standardize array index check
ParseArrayIndex() was requesting a Uint32Value(), but assigning it to an
in32_t. This caused slight differences in error message reported in edge
cases of argument parsing. Fixed by getting the IntegerValue() before
checking if the value is < 0. Added test of API that was affected.
PR-URL: #6084
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 440d117 commit d44540fCopy full SHA for d44540f
File tree
Expand file treeCollapse file tree
2 files changed
+7
-1
lines changedOpen diff view settings
Filter options
- src
- test/parallel
Expand file treeCollapse file tree
2 files changed
+7
-1
lines changedOpen diff view settings
Collapse file
+1-1Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
167 | 167 | |
168 | 168 | |
169 | 169 | |
170 | | - |
| 170 | + |
171 | 171 | |
172 | 172 | |
173 | 173 | |
|
Collapse file
test/parallel/test-buffer-alloc.js
Copy file name to clipboardExpand all lines: test/parallel/test-buffer-alloc.js+6Lines changed: 6 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
1429 | 1429 | |
1430 | 1430 | |
1431 | 1431 | |
| 1432 | + |
| 1433 | + |
| 1434 | + |
| 1435 | + |
| 1436 | + |
| 1437 | + |
0 commit comments