Commit d3d62ed
src: distinguish env stopping flags
`Environment::FreeEnvironment` creates a
`DisallowJavascriptExecutionScope`, so the flag
`Environment::can_call_into_js()` should also be set as `false`. As
`Environment::can_call_into_js_` is a simple boolean flag, it should not
be accessed off-threads.
PR-URL: #45907
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>1 parent 1cfa2e6 commit d3d62edCopy full SHA for d3d62ed
File tree
Expand file treeCollapse file tree
5 files changed
+11
-4
lines changedOpen diff view settings
Filter options
- src
- api
Expand file treeCollapse file tree
5 files changed
+11
-4
lines changedOpen diff view settings
Collapse file
+3Lines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
424 | 424 | |
425 | 425 | |
426 | 426 | |
| 427 | + |
| 428 | + |
| 429 | + |
427 | 430 | |
428 | 431 | |
429 | 432 | |
|
Collapse file
+5-2Lines changed: 5 additions & 2 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
909 | 909 | |
910 | 910 | |
911 | 911 | |
912 | | - |
| 912 | + |
913 | 913 | |
914 | 914 | |
915 | | - |
| 915 | + |
| 916 | + |
| 917 | + |
| 918 | + |
916 | 919 | |
917 | 920 | |
918 | 921 | |
|
Collapse file
+1Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
778 | 778 | |
779 | 779 | |
780 | 780 | |
| 781 | + |
781 | 782 | |
782 | 783 | |
783 | 784 | |
|
Collapse file
+1-1Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
1127 | 1127 | |
1128 | 1128 | |
1129 | 1129 | |
1130 | | - |
| 1130 | + |
1131 | 1131 | |
1132 | 1132 | |
1133 | 1133 | |
|
Collapse file
+1-1Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
609 | 609 | |
610 | 610 | |
611 | 611 | |
612 | | - |
| 612 | + |
613 | 613 | |
614 | 614 | |
615 | 615 | |
|
0 commit comments