Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit d3a70e9

Browse filesBrowse files
TrottMylesBorins
authored andcommitted
doc: remove tentativeness in pull-requests.md
There are some uses of "in general" that are unnecessary. (We don't need to be tentative about the fact that tests should pass, for example.) PR-URL: #19123 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent f03079f commit d3a70e9
Copy full SHA for d3a70e9

File tree

Expand file treeCollapse file tree

1 file changed

+6
-6
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+6
-6
lines changed
Open diff view settings
Collapse file

‎doc/guides/contributing/pull-requests.md‎

Copy file name to clipboardExpand all lines: doc/guides/contributing/pull-requests.md
+6-6Lines changed: 6 additions & 6 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -401,10 +401,10 @@ seem unfamiliar, refer to this
401401
All Pull Requests require "sign off" in order to land. Whenever a contributor
402402
reviews a Pull Request they may find specific details that they would like to
403403
see changed or fixed. These may be as simple as fixing a typo, or may involve
404-
substantive changes to the code you have written. In general, such requests
405-
are intended to be helpful, but at times may come across as abrupt or unhelpful,
406-
especially requests to change things that do not include concrete suggestions
407-
on *how* to change them.
404+
substantive changes to the code you have written. While such requests are
405+
intended to be helpful, they may come across as abrupt or unhelpful, especially
406+
requests to change things that do not include concrete suggestions on *how* to
407+
change them.
408408

409409
Try not to be discouraged. If you feel that a particular review is unfair,
410410
say so, or contact one of the other contributors in the project and seek their
@@ -610,8 +610,8 @@ however, will stay intact on the Pull Request page.
610610
For the size of "one logical change",
611611
[0b5191f](https://github.com/nodejs/node/commit/0b5191f15d0f311c804d542b67e2e922d98834f8)
612612
can be a good example. It touches the implementation, the documentation,
613-
and the tests, but is still one logical change. In general, the tests should
614-
always pass when each individual commit lands on the master branch.
613+
and the tests, but is still one logical change. All tests should always pass
614+
when each individual commit lands on the master branch.
615615

616616
### Getting Approvals for Your Pull Request
617617

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.