Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit d384911

Browse filesBrowse files
Trotttargos
authored andcommitted
doc: remove "note that" from async_hooks.md
PR-URL: #28329 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent 9ca7c86 commit d384911
Copy full SHA for d384911

File tree

Expand file treeCollapse file tree

1 file changed

+5
-5
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+5
-5
lines changed
Open diff view settings
Collapse file

‎doc/api/async_hooks.md‎

Copy file name to clipboardExpand all lines: doc/api/async_hooks.md
+5-5Lines changed: 5 additions & 5 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ const asyncHook = async_hooks.createHook({
111111
});
112112
```
113113

114-
Note that the callbacks will be inherited via the prototype chain:
114+
The callbacks will be inherited via the prototype chain:
115115

116116
```js
117117
class MyAsyncCallbacks {
@@ -439,7 +439,7 @@ added: v8.6.0
439439
Called when the `resolve` function passed to the `Promise` constructor is
440440
invoked (either directly or through other means of resolving a promise).
441441

442-
Note that `resolve()` does not do any observable synchronous work.
442+
`resolve()` does not do any observable synchronous work.
443443

444444
The `Promise` is not necessarily fulfilled or rejected at this point if the
445445
`Promise` was resolved by assuming the state of another `Promise`.
@@ -497,7 +497,7 @@ const server = net.createServer((conn) => {
497497
});
498498
```
499499

500-
Note that promise contexts may not get precise `executionAsyncIds` by default.
500+
Promise contexts may not get precise `executionAsyncIds` by default.
501501
See the section on [promise execution tracking][].
502502

503503
#### async_hooks.triggerAsyncId()
@@ -520,7 +520,7 @@ const server = net.createServer((conn) => {
520520
});
521521
```
522522

523-
Note that promise contexts may not get valid `triggerAsyncId`s by default. See
523+
Promise contexts may not get valid `triggerAsyncId`s by default. See
524524
the section on [promise execution tracking][].
525525

526526
## Promise execution tracking
@@ -540,7 +540,7 @@ Promise.resolve(1729).then(() => {
540540
```
541541

542542
Observe that the `then()` callback claims to have executed in the context of the
543-
outer scope even though there was an asynchronous hop involved. Also note that
543+
outer scope even though there was an asynchronous hop involved. Also,
544544
the `triggerAsyncId` value is `0`, which means that we are missing context about
545545
the resource that caused (triggered) the `then()` callback to be executed.
546546

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.