Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit d2fea9f

Browse filesBrowse files
mkrawczukMylesBorins
authored andcommitted
http2: rename counter in mapToHeaders inner loop
This change is to prevent potential bugs - e.g., someone might automatically use the variable `k` instead of `key`, that is used in vicinity of this loop. Also changed postincrement to preincrement in iteration steps. It is probably done by the optimizer anyway, but otherwise it will save an opcode each iteration. And it is a good practice. PR-URL: #32012 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent c0af3ac commit d2fea9f
Copy full SHA for d2fea9f

File tree

Expand file treeCollapse file tree

1 file changed

+4
-4
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+4
-4
lines changed
Open diff view settings
Collapse file

‎lib/internal/http2/util.js‎

Copy file name to clipboardExpand all lines: lib/internal/http2/util.js
+4-4Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -442,13 +442,13 @@ function mapToHeaders(map,
442442
let count = 0;
443443
const keys = ObjectKeys(map);
444444
const singles = new Set();
445-
let i;
445+
let i, j;
446446
let isArray;
447447
let key;
448448
let value;
449449
let isSingleValueHeader;
450450
let err;
451-
for (i = 0; i < keys.length; i++) {
451+
for (i = 0; i < keys.length; ++i) {
452452
key = keys[i];
453453
value = map[key];
454454
if (value === undefined || key === '')
@@ -488,8 +488,8 @@ function mapToHeaders(map,
488488
throw new ERR_HTTP2_INVALID_CONNECTION_HEADERS(key);
489489
}
490490
if (isArray) {
491-
for (var k = 0; k < value.length; k++) {
492-
const val = String(value[k]);
491+
for (j = 0; j < value.length; ++j) {
492+
const val = String(value[j]);
493493
ret += `${key}\0${val}\0`;
494494
}
495495
count += value.length;

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.