Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit d2d9453

Browse filesBrowse files
cjihrigaddaleax
authored andcommitted
report: simplify heap space iteration
PR-URL: #26285 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 88256d7 commit d2d9453
Copy full SHA for d2d9453

File tree

Expand file treeCollapse file tree

1 file changed

+2
-15
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-15
lines changed
Open diff view settings
Collapse file

‎src/node_report.cc‎

Copy file name to clipboardExpand all lines: src/node_report.cc
+2-15Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -447,8 +447,7 @@ static void PrintGCStatistics(JSONWriter* writer, Isolate* isolate) {
447447

448448
writer->json_objectstart("heapSpaces");
449449
// Loop through heap spaces
450-
size_t i;
451-
for (i = 0; i < isolate->NumberOfHeapSpaces() - 1; i++) {
450+
for (size_t i = 0; i < isolate->NumberOfHeapSpaces(); i++) {
452451
isolate->GetHeapSpaceStatistics(&v8_heap_space_stats, i);
453452
writer->json_objectstart(v8_heap_space_stats.space_name());
454453
writer->json_keyvalue("memorySize", v8_heap_space_stats.space_size());
@@ -464,19 +463,7 @@ static void PrintGCStatistics(JSONWriter* writer, Isolate* isolate) {
464463
"available", v8_heap_space_stats.space_available_size());
465464
writer->json_objectend();
466465
}
467-
isolate->GetHeapSpaceStatistics(&v8_heap_space_stats, i);
468-
writer->json_objectstart(v8_heap_space_stats.space_name());
469-
writer->json_keyvalue("memorySize", v8_heap_space_stats.space_size());
470-
writer->json_keyvalue(
471-
"committedMemory", v8_heap_space_stats.physical_space_size());
472-
writer->json_keyvalue(
473-
"capacity",
474-
v8_heap_space_stats.space_used_size() +
475-
v8_heap_space_stats.space_available_size());
476-
writer->json_keyvalue("used", v8_heap_space_stats.space_used_size());
477-
writer->json_keyvalue(
478-
"available", v8_heap_space_stats.space_available_size());
479-
writer->json_objectend();
466+
480467
writer->json_objectend();
481468
writer->json_objectend();
482469
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.