Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit d27ec13

Browse filesBrowse files
priyank-pgibfahn
authored andcommitted
repl: avoid crashing from null and undefined errors
When `throw undefined` or `throw null` is executed, the REPL crashes. This change does a check for `null|undefined` before accessing an error's properties to prevent crashing. Fixes: #16545 Fixes: #16607 PR-URL: #16574 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
1 parent 981a1ef commit d27ec13
Copy full SHA for d27ec13

File tree

Expand file treeCollapse file tree

2 files changed

+21
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+21
-2
lines changed
Open diff view settings
Collapse file

‎lib/repl.js‎

Copy file name to clipboardExpand all lines: lib/repl.js
+3-2Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -255,12 +255,13 @@ function REPLServer(prompt,
255255
}
256256
} catch (e) {
257257
err = e;
258-
if (err.message === 'Script execution interrupted.') {
258+
259+
if (err && err.message === 'Script execution interrupted.') {
259260
// The stack trace for this case is not very useful anyway.
260261
Object.defineProperty(err, 'stack', { value: '' });
261262
}
262263

263-
if (err && process.domain) {
264+
if (process.domain) {
264265
debug('not recoverable, send to domain');
265266
process.domain.emit('error', err);
266267
process.domain.exit();
Collapse file
+18Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
'use strict';
2+
require('../common');
3+
4+
// This test ensures that the repl does not
5+
// crash or emit error when throwing `null|undefined`
6+
// ie `throw null` or `throw undefined`
7+
8+
const assert = require('assert');
9+
const repl = require('repl');
10+
11+
const r = repl.start();
12+
13+
assert.doesNotThrow(() => {
14+
r.write('throw null\n');
15+
r.write('throw undefined\n');
16+
}, TypeError, 'repl crashes/throw error on `throw null|undefined`');
17+
18+
r.write('.exit\n');

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.