Commit d1307b2
src: don't use fopen() in require() fast path
Fix a regression that was introduced in commit 1bbf8d0 ("lib: speed up
require(), phase 2") where file paths with Unicode characters fail to
load on Windows.
Fixes: #2236
PR-URL: #2377
Reviewed-By: Bert Belder <bertbelder@gmail.com>1 parent 3645dc6 commit d1307b2Copy full SHA for d1307b2
File tree
Expand file treeCollapse file tree
2 files changed
+40
-7
lines changedOpen diff view settings
Filter options
- src
- test/parallel
Expand file treeCollapse file tree
2 files changed
+40
-7
lines changedOpen diff view settings
Collapse file
+24-7Lines changed: 24 additions & 7 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
442 | 442 | |
443 | 443 | |
444 | 444 | |
| 445 | + |
445 | 446 | |
446 | 447 | |
447 | 448 | |
448 | 449 | |
449 | | - |
450 | | - |
| 450 | + |
| 451 | + |
| 452 | + |
| 453 | + |
| 454 | + |
451 | 455 | |
452 | 456 | |
453 | 457 | |
454 | 458 | |
455 | | - |
| 459 | + |
| 460 | + |
456 | 461 | |
457 | 462 | |
458 | 463 | |
459 | | - |
460 | | - |
| 464 | + |
| 465 | + |
| 466 | + |
| 467 | + |
| 468 | + |
| 469 | + |
| 470 | + |
| 471 | + |
| 472 | + |
| 473 | + |
| 474 | + |
| 475 | + |
461 | 476 | |
462 | 477 | |
463 | 478 | |
464 | 479 | |
465 | 480 | |
| 481 | + |
466 | 482 | |
467 | 483 | |
468 | | - |
469 | | - |
| 484 | + |
| 485 | + |
| 486 | + |
470 | 487 | |
471 | 488 | |
472 | 489 | |
|
Collapse file
test/parallel/test-require-unicode.js
Copy file name to clipboard+16Lines changed: 16 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
| 1 | + |
| 2 | + |
| 3 | + |
| 4 | + |
| 5 | + |
| 6 | + |
| 7 | + |
| 8 | + |
| 9 | + |
| 10 | + |
| 11 | + |
| 12 | + |
| 13 | + |
| 14 | + |
| 15 | + |
| 16 | + |
0 commit comments