Commit d0f73d3
authored
build: go faster, drop -fno-omit-frame-pointer
This flag was added back in 2013 to support postmortem debugging on
Linux but it has a pretty bad impact on performance (up to 10%) and
I don't think it's actually necessary to get meaningful stack traces.
Maybe with mdb but gdb and lldb seem to manage just fine.
Even if the flag is necessary for postmortem debugging, I don't think
it's appropriate to make performance for all users suffer for the
benefit of a fringe group.
PR-URL: #44452
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>1 parent 1a0a058 commit d0f73d3Copy full SHA for d0f73d3
File tree
Expand file treeCollapse file tree
1 file changed
+1
-3
lines changedOpen diff view settings
Filter options
Expand file treeCollapse file tree
1 file changed
+1
-3
lines changedOpen diff view settings
Collapse file
+1-3Lines changed: 1 addition & 3 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
204 | 204 | |
205 | 205 | |
206 | 206 | |
| 207 | + |
207 | 208 | |
208 | 209 | |
209 | 210 | |
210 | 211 | |
211 | 212 | |
212 | 213 | |
213 | 214 | |
214 | | - |
215 | | - |
216 | | - |
217 | 215 | |
218 | 216 | |
219 | 217 | |
|
0 commit comments