Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit d0f73d3

Browse filesBrowse files
authored
build: go faster, drop -fno-omit-frame-pointer
This flag was added back in 2013 to support postmortem debugging on Linux but it has a pretty bad impact on performance (up to 10%) and I don't think it's actually necessary to get meaningful stack traces. Maybe with mdb but gdb and lldb seem to manage just fine. Even if the flag is necessary for postmortem debugging, I don't think it's appropriate to make performance for all users suffer for the benefit of a fringe group. PR-URL: #44452 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
1 parent 1a0a058 commit d0f73d3
Copy full SHA for d0f73d3

File tree

Expand file treeCollapse file tree

1 file changed

+1
-3
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-3
lines changed
Open diff view settings
Collapse file

‎common.gypi‎

Copy file name to clipboardExpand all lines: common.gypi
+1-3Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -204,16 +204,14 @@
204204
],
205205
}],
206206
['OS=="solaris"', {
207+
'cflags': [ '-fno-omit-frame-pointer' ],
207208
# pull in V8's postmortem metadata
208209
'ldflags': [ '-Wl,-z,allextract' ]
209210
}],
210211
['OS=="zos"', {
211212
# increase performance, number from experimentation
212213
'cflags': [ '-qINLINE=::150:100000' ]
213214
}],
214-
['OS!="mac" and OS!="win" and OS!="zos"', {
215-
'cflags': [ '-fno-omit-frame-pointer' ],
216-
}],
217215
['OS=="linux"', {
218216
'conditions': [
219217
['enable_pgo_generate=="true"', {

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.