Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit d01eb68

Browse filesBrowse files
JungMinujasnell
authored andcommitted
lib: add 'pid' prefix in internal/util
This PR improves `prefix` in `util` that we've agreed on #3833 (separate code for javascript to move the printing function to C++ directly) PR-URL: #3878 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent ca2e8b2 commit d01eb68
Copy full SHA for d01eb68

File tree

Expand file treeCollapse file tree

2 files changed

+2
-3
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+2
-3
lines changed
Open diff view settings
Collapse file

‎lib/internal/util.js‎

Copy file name to clipboardExpand all lines: lib/internal/util.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
'use strict';
22

3-
const prefix = '(node) ';
3+
const prefix = `(${process.release.name}:${process.pid}) `;
44

55
// All the internal deprecations have to use this function only, as this will
66
// prepend the prefix to the actual message.
Collapse file

‎test/sequential/test-deprecation-flags.js‎

Copy file name to clipboardExpand all lines: test/sequential/test-deprecation-flags.js
+1-2Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,7 @@ execFile(node, normal, function(er, stdout, stderr) {
1616
console.error('normal: show deprecation warning');
1717
assert.equal(er, null);
1818
assert.equal(stdout, '');
19-
assert.equal(stderr, '(node) util.debug is deprecated. Use console.error ' +
20-
'instead.\nDEBUG: This is deprecated\n');
19+
assert(/util\.debug is deprecated/.test(stderr));
2120
console.log('normal ok');
2221
});
2322

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.