Commit cf071a0
stream: resolve perf regression introduced by V8 7.3
This commit contains two fixes:
1. use instanceof instead of Object.getPrototypeOf, as checking an
object prototype with Object.getPrototypeOf is slower
than an instanceof check.
2. avoid parseInt(undefined, 10) to get NaN as it regressed.
PR-URL: #28842
Fixes: #28586
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>1 parent e6b3bfe commit cf071a0Copy full SHA for cf071a0
File tree
Expand file treeCollapse file tree
2 files changed
+11
-3
lines changedOpen diff view settings
Filter options
- lib
Expand file treeCollapse file tree
2 files changed
+11
-3
lines changedOpen diff view settings
Collapse file
+9-2Lines changed: 9 additions & 2 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
250 | 250 | |
251 | 251 | |
252 | 252 | |
253 | | - |
| 253 | + |
| 254 | + |
254 | 255 | |
255 | 256 | |
256 | 257 | |
| ||
393 | 394 | |
394 | 395 | |
395 | 396 | |
396 | | - |
| 397 | + |
| 398 | + |
| 399 | + |
| 400 | + |
| 401 | + |
| 402 | + |
| 403 | + |
397 | 404 | |
398 | 405 | |
399 | 406 | |
|
Collapse file
+2-1Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
277 | 277 | |
278 | 278 | |
279 | 279 | |
280 | | - |
| 280 | + |
| 281 | + |
281 | 282 | |
282 | 283 | |
283 | 284 | |
|
0 commit comments