Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit cedd26a

Browse filesBrowse files
VoltrexKeyvaruyadorno
authored andcommitted
lib: refactor source map stack trace prepare
• Make use of the logical OR operator (`||`) for better readability. • Remove unnecessary conditional and wrapping. PR-URL: #41698 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 5f1a59c commit cedd26a
Copy full SHA for cedd26a

File tree

Expand file treeCollapse file tree

1 file changed

+3
-3
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+3
-3
lines changed
Open diff view settings
Collapse file

‎lib/internal/source_map/prepare_stack_trace.js‎

Copy file name to clipboardExpand all lines: lib/internal/source_map/prepare_stack_trace.js
+3-3Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -89,12 +89,12 @@ const prepareStackTrace = (globalThis, error, trace) => {
8989
// Construct call site name based on: v8.dev/docs/stack-trace-api:
9090
const fnName = t.getFunctionName() ?? t.getMethodName();
9191
const originalName = `${t.getTypeName() !== 'global' ?
92-
`${t.getTypeName()}.` : ''}${fnName ? fnName : '<anonymous>'}`;
92+
`${t.getTypeName()}.` : ''}${fnName || '<anonymous>'}`;
9393
// The original call site may have a different symbol name
9494
// associated with it, use it:
9595
const prefix = (name && name !== originalName) ?
9696
`${name}` :
97-
`${originalName ? originalName : ''}`;
97+
`${originalName}`;
9898
const hasName = !!(name || originalName);
9999
const originalSourceNoScheme =
100100
StringPrototypeStartsWith(originalSource, 'file://') ?
@@ -160,7 +160,7 @@ function getErrorSource(
160160
let prefix = '';
161161
for (const character of new SafeStringIterator(
162162
StringPrototypeSlice(line, 0, originalColumn + 1))) {
163-
prefix += (character === '\t') ? '\t' :
163+
prefix += character === '\t' ? '\t' :
164164
StringPrototypeRepeat(' ', getStringWidth(character));
165165
}
166166
prefix = StringPrototypeSlice(prefix, 0, -1); // The last character is '^'.

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.