Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit cedba09

Browse filesBrowse files
joyeecheungaduh95
joyeecheung
authored and
aduh95
committed
test: move sea tests into test/sea
This makes skipping/running these tests easier to manage with a dedicated test runner that can be tweaked for SEA. PR-URL: #60250 Refs: #59553 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
1 parent eb8a049 commit cedba09
Copy full SHA for cedba09
Expand file treeCollapse file tree

24 files changed

+105
-107
lines changed
Open diff view settings
Collapse file

‎.github/CODEOWNERS‎

Copy file name to clipboardExpand all lines: .github/CODEOWNERS
+1-2Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -158,8 +158,7 @@
158158
/doc/contributing/maintaining/maintaining-single-executable-application-support.md @nodejs/single-executable
159159
/src/node_sea* @nodejs/single-executable
160160
/test/fixtures/postject-copy @nodejs/single-executable
161-
/test/parallel/test-single-executable-* @nodejs/single-executable
162-
/test/sequential/test-single-executable-* @nodejs/single-executable
161+
/test/sea @nodejs/single-executable
163162
/tools/dep_updaters/update-postject.sh @nodejs/single-executable
164163

165164
# Permission Model
Collapse file

‎test/sea/sea.status‎

Copy file name to clipboard
+38Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
prefix sea
2+
3+
# To mark a test as flaky, list the test name in the appropriate section
4+
# below, without ".js", followed by ": PASS,FLAKY". Example:
5+
# sample-test : PASS,FLAKY
6+
7+
[true] # This section applies to all platforms
8+
9+
[$system==macos && $arch==x64]
10+
# https://github.com/nodejs/node/issues/59553
11+
test-single-executable-application: PASS, FLAKY
12+
test-single-executable-application-assets: PASS, FLAKY
13+
test-single-executable-application-assets-raw: PASS, FLAKY
14+
test-single-executable-application-asset-keys-empty: PASS, FLAKY
15+
test-single-executable-application-asset-keys: PASS, FLAKY
16+
test-single-executable-application-disable-experimental-sea-warning: PASS, FLAKY
17+
test-single-executable-application-empty: PASS, FLAKY
18+
test-single-executable-application-exec-argv: PASS, FLAKY
19+
test-single-executable-application-exec-argv-empty: PASS, FLAKY
20+
test-single-executable-application-exec-argv-extension-cli: PASS, FLAKY
21+
test-single-executable-application-exec-argv-extension-env: PASS, FLAKY
22+
test-single-executable-application-exec-argv-extension-none: PASS, FLAKY
23+
test-single-executable-application-inspect-in-sea-flags: PASS, FLAKY
24+
test-single-executable-application-inspect: PASS, FLAKY
25+
test-single-executable-application-snapshot: PASS, FLAKY
26+
test-single-executable-application-snapshot-and-code-cache: PASS, FLAKY
27+
test-single-executable-application-snapshot-worker: PASS, FLAKY
28+
test-single-executable-application-use-code-cache: PASS, FLAKY
29+
30+
31+
[$system==linux && $arch==ppc64]
32+
# https://github.com/nodejs/node/issues/59561
33+
test-single-executable-application*: SKIP
34+
35+
[$system==win32]
36+
# https://github.com/nodejs/node/issues/49630
37+
test-single-executable-application-snapshot: PASS, FLAKY
38+
test-single-executable-application-snapshot-and-code-cache: PASS, FLAKY
Collapse file

‎…ecutable-application-asset-keys-empty.js‎ ‎…ecutable-application-asset-keys-empty.js‎test/sequential/test-single-executable-application-asset-keys-empty.js renamed to test/sea/test-single-executable-application-asset-keys-empty.js test/sequential/test-single-executable-application-asset-keys-empty.js renamed to test/sea/test-single-executable-application-asset-keys-empty.js

Copy file name to clipboardExpand all lines: test/sea/test-single-executable-application-asset-keys-empty.js
+3-3Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ spawnSyncAndExitWithoutError(
4343
NODE_DEBUG_NATIVE: 'SEA',
4444
...process.env,
4545
},
46-
cwd: tmpdir.path
46+
cwd: tmpdir.path,
4747
},
4848
{});
4949

@@ -57,9 +57,9 @@ spawnSyncAndAssert(
5757
env: {
5858
...process.env,
5959
NODE_DEBUG_NATIVE: 'SEA',
60-
}
60+
},
6161
},
6262
{
6363
stdout: /Asset keys: \[\]/,
64-
}
64+
},
6565
);
Collapse file

‎…gle-executable-application-asset-keys.js‎ ‎…gle-executable-application-asset-keys.js‎test/sequential/test-single-executable-application-asset-keys.js renamed to test/sea/test-single-executable-application-asset-keys.js test/sequential/test-single-executable-application-asset-keys.js renamed to test/sea/test-single-executable-application-asset-keys.js

Copy file name to clipboardExpand all lines: test/sea/test-single-executable-application-asset-keys.js
+3-3Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ spawnSyncAndExitWithoutError(
5252
NODE_DEBUG_NATIVE: 'SEA',
5353
...process.env,
5454
},
55-
cwd: tmpdir.path
55+
cwd: tmpdir.path,
5656
},
5757
{});
5858

@@ -66,9 +66,9 @@ spawnSyncAndAssert(
6666
env: {
6767
...process.env,
6868
NODE_DEBUG_NATIVE: 'SEA',
69-
}
69+
},
7070
},
7171
{
7272
stdout: /Asset keys: \["asset-1\.txt","asset-2\.txt","asset-3\.txt"\]/,
73-
}
73+
},
7474
);
Collapse file

‎…gle-executable-application-assets-raw.js‎ ‎…gle-executable-application-assets-raw.js‎test/sequential/test-single-executable-application-assets-raw.js renamed to test/sea/test-single-executable-application-assets-raw.js test/sequential/test-single-executable-application-assets-raw.js renamed to test/sea/test-single-executable-application-assets-raw.js

Copy file name to clipboardExpand all lines: test/sea/test-single-executable-application-assets-raw.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ const outputFile = tmpdir.resolve(process.platform === 'win32' ? 'sea.exe' : 'se
5050
NODE_DEBUG_NATIVE: 'SEA',
5151
...process.env,
5252
},
53-
cwd: tmpdir.path
53+
cwd: tmpdir.path,
5454
});
5555

5656
assert(existsSync(seaPrepBlob));
@@ -64,7 +64,7 @@ const outputFile = tmpdir.resolve(process.platform === 'win32' ? 'sea.exe' : 'se
6464
...process.env,
6565
NODE_DEBUG_NATIVE: 'SEA',
6666
__TEST_PERSON_JPG: fixtures.path('person.jpg'),
67-
}
67+
},
6868
},
6969
);
7070
}
Collapse file

‎…-single-executable-application-assets.js‎ ‎…-single-executable-application-assets.js‎test/sequential/test-single-executable-application-assets.js renamed to test/sea/test-single-executable-application-assets.js test/sequential/test-single-executable-application-assets.js renamed to test/sea/test-single-executable-application-assets.js

Copy file name to clipboardExpand all lines: test/sea/test-single-executable-application-assets.js
+7-7Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -45,12 +45,12 @@ const outputFile = tmpdir.resolve(process.platform === 'win32' ? 'sea.exe' : 'se
4545
process.execPath,
4646
['--experimental-sea-config', 'sea-config.json'],
4747
{
48-
cwd: tmpdir.path
48+
cwd: tmpdir.path,
4949
},
5050
{
5151
status: 1,
5252
signal: null,
53-
stderr: /"assets" field of sea-config\.json is not a map of strings/
53+
stderr: /"assets" field of sea-config\.json is not a map of strings/,
5454
});
5555
}
5656

@@ -71,12 +71,12 @@ const outputFile = tmpdir.resolve(process.platform === 'win32' ? 'sea.exe' : 'se
7171
process.execPath,
7272
['--experimental-sea-config', 'sea-config.json'],
7373
{
74-
cwd: tmpdir.path
74+
cwd: tmpdir.path,
7575
},
7676
{
7777
status: 1,
7878
signal: null,
79-
stderr: /Cannot read asset nonexistent\.txt: no such file or directory/
79+
stderr: /Cannot read asset nonexistent\.txt: no such file or directory/,
8080
});
8181
}
8282

@@ -104,7 +104,7 @@ const outputFile = tmpdir.resolve(process.platform === 'win32' ? 'sea.exe' : 'se
104104
NODE_DEBUG_NATIVE: 'SEA',
105105
...process.env,
106106
},
107-
cwd: tmpdir.path
107+
cwd: tmpdir.path,
108108
});
109109

110110
assert(existsSync(seaPrepBlob));
@@ -119,11 +119,11 @@ const outputFile = tmpdir.resolve(process.platform === 'win32' ? 'sea.exe' : 'se
119119
NODE_DEBUG_NATIVE: 'SEA',
120120
__TEST_PERSON_JPG: fixtures.path('person.jpg'),
121121
__TEST_UTF8_TEXT_PATH: fixtures.path('utf8_test_text.txt'),
122-
}
122+
},
123123
},
124124
{
125125
trim: true,
126126
stdout: fixtures.utf8TestText,
127-
}
127+
},
128128
);
129129
}
Collapse file

‎…tion-disable-experimental-sea-warning.js‎ ‎…tion-disable-experimental-sea-warning.js‎test/sequential/test-single-executable-application-disable-experimental-sea-warning.js renamed to test/sea/test-single-executable-application-disable-experimental-sea-warning.js test/sequential/test-single-executable-application-disable-experimental-sea-warning.js renamed to test/sea/test-single-executable-application-disable-experimental-sea-warning.js

Copy file name to clipboardExpand all lines: test/sea/test-single-executable-application-disable-experimental-sea-warning.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,8 @@ spawnSyncAndAssert(
6060
COMMON_DIRECTORY: join(__dirname, '..', 'common'),
6161
NODE_DEBUG_NATIVE: 'SEA',
6262
...process.env,
63-
}
63+
},
6464
},
6565
{
66-
stdout: 'Hello, world! 😊\n'
66+
stdout: 'Hello, world! 😊\n',
6767
});
Collapse file

‎…t-single-executable-application-empty.js‎ ‎…t-single-executable-application-empty.js‎test/sequential/test-single-executable-application-empty.js renamed to test/sea/test-single-executable-application-empty.js test/sequential/test-single-executable-application-empty.js renamed to test/sea/test-single-executable-application-empty.js

Copy file name to clipboardExpand all lines: test/sea/test-single-executable-application-empty.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,5 +59,5 @@ spawnSyncAndExitWithoutError(
5959
env: {
6060
NODE_DEBUG_NATIVE: 'SEA',
6161
...process.env,
62-
}
62+
},
6363
});
Collapse file

‎…xecutable-application-exec-argv-empty.js‎ ‎…xecutable-application-exec-argv-empty.js‎test/sequential/test-single-executable-application-exec-argv-empty.js renamed to test/sea/test-single-executable-application-exec-argv-empty.js test/sequential/test-single-executable-application-exec-argv-empty.js renamed to test/sea/test-single-executable-application-exec-argv-empty.js

Copy file name to clipboardExpand all lines: test/sea/test-single-executable-application-exec-argv-empty.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,8 @@ spawnSyncAndAssert(
5454
COMMON_DIRECTORY: join(__dirname, '..', 'common'),
5555
NODE_DEBUG_NATIVE: 'SEA',
5656
...process.env,
57-
}
57+
},
5858
},
5959
{
60-
stdout: /empty execArgv test passed/
60+
stdout: /empty execArgv test passed/,
6161
});
Collapse file

‎…e-application-exec-argv-extension-cli.js‎ ‎…e-application-exec-argv-extension-cli.js‎test/sequential/test-single-executable-application-exec-argv-extension-cli.js renamed to test/sea/test-single-executable-application-exec-argv-extension-cli.js test/sequential/test-single-executable-application-exec-argv-extension-cli.js renamed to test/sea/test-single-executable-application-exec-argv-extension-cli.js

Copy file name to clipboardExpand all lines: test/sea/test-single-executable-application-exec-argv-extension-cli.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,8 @@ spawnSyncAndAssert(
5656
NODE_OPTIONS: '--max-old-space-size=2048', // Should be ignored
5757
COMMON_DIRECTORY: join(__dirname, '..', 'common'),
5858
NODE_DEBUG_NATIVE: 'SEA',
59-
}
59+
},
6060
},
6161
{
62-
stdout: /execArgvExtension cli test passed/
62+
stdout: /execArgvExtension cli test passed/,
6363
});

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.