Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit cec5e36

Browse filesBrowse files
imyllerMyles Borins
authored andcommitted
test: fix test-cluster-worker-init.js flakyness
Update test to match current test guidelines and use common.mustCall instead of unref'd timer. PR-URL: #8703 Fixes: #8700 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
1 parent b3fccc2 commit cec5e36
Copy full SHA for cec5e36

File tree

Expand file treeCollapse file tree

1 file changed

+10
-15
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+10
-15
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-cluster-worker-init.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-cluster-worker-init.js
+10-15Lines changed: 10 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -3,30 +3,25 @@
33
// verifies that, when a child process is forked, the cluster.worker
44
// object can receive messages as expected
55

6-
require('../common');
7-
var assert = require('assert');
8-
var cluster = require('cluster');
9-
var msg = 'foo';
6+
const common = require('../common');
7+
const assert = require('assert');
8+
const cluster = require('cluster');
9+
const msg = 'foo';
1010

1111
if (cluster.isMaster) {
12-
var worker = cluster.fork();
13-
var timer = setTimeout(function() {
14-
assert(false, 'message not received');
15-
}, 5000);
12+
const worker = cluster.fork();
1613

17-
timer.unref();
18-
19-
worker.on('message', function(message) {
20-
assert(message, 'did not receive expected message');
14+
worker.on('message', common.mustCall((message) => {
15+
assert.strictEqual(message, true, 'did not receive expected message');
2116
worker.disconnect();
22-
});
17+
}));
2318

24-
worker.on('online', function() {
19+
worker.on('online', () => {
2520
worker.send(msg);
2621
});
2722
} else {
2823
// GH #7998
29-
cluster.worker.on('message', function(message) {
24+
cluster.worker.on('message', (message) => {
3025
process.send(message === msg);
3126
});
3227
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.