Commit ce3586d
timers: warn on overflowed timeout duration
Cherry-pick from ayo
Ayo commit log:
> Previously there wasn't any clear indicator when you hit the overflow
> other than possibly unexpected behavior, and I think emitting a warning
> may be appropriate.
> PR-URL: ayojs/ayo#71
> Reviewed-By: Scott Trinh <scott@scotttrinh.com>
> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
> Reviewed-By: Anna Henningsen <anna@addaleax.net>
> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: #15627
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>1 parent 4843c2f commit ce3586dCopy full SHA for ce3586d
File tree
Expand file treeCollapse file tree
2 files changed
+59
-2
lines changedOpen diff view settings
Filter options
- lib
- test/parallel
Expand file treeCollapse file tree
2 files changed
+59
-2
lines changedOpen diff view settings
Collapse file
+19-2Lines changed: 19 additions & 2 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
398 | 398 | |
399 | 399 | |
400 | 400 | |
| 401 | + |
| 402 | + |
| 403 | + |
401 | 404 | |
402 | 405 | |
403 | 406 | |
| ||
442 | 445 | |
443 | 446 | |
444 | 447 | |
445 | | - |
| 448 | + |
| 449 | + |
| 450 | + |
| 451 | + |
| 452 | + |
| 453 | + |
| 454 | + |
446 | 455 | |
| 456 | + |
447 | 457 | |
448 | 458 | |
449 | 459 | |
| ||
531 | 541 | |
532 | 542 | |
533 | 543 | |
534 | | - |
| 544 | + |
| 545 | + |
| 546 | + |
| 547 | + |
| 548 | + |
| 549 | + |
| 550 | + |
535 | 551 | |
| 552 | + |
536 | 553 | |
537 | 554 | |
538 | 555 | |
|
Collapse file
test/parallel/test-timers-max-duration-warning.js
Copy file name to clipboard+40Lines changed: 40 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
| 1 | + |
| 2 | + |
| 3 | + |
| 4 | + |
| 5 | + |
| 6 | + |
| 7 | + |
| 8 | + |
| 9 | + |
| 10 | + |
| 11 | + |
| 12 | + |
| 13 | + |
| 14 | + |
| 15 | + |
| 16 | + |
| 17 | + |
| 18 | + |
| 19 | + |
| 20 | + |
| 21 | + |
| 22 | + |
| 23 | + |
| 24 | + |
| 25 | + |
| 26 | + |
| 27 | + |
| 28 | + |
| 29 | + |
| 30 | + |
| 31 | + |
| 32 | + |
| 33 | + |
| 34 | + |
| 35 | + |
| 36 | + |
| 37 | + |
| 38 | + |
| 39 | + |
| 40 | + |
0 commit comments