Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit cde3014

Browse filesBrowse files
TrottMyles Borins
Trott
authored and
Myles Borins
committed
test: remove modifcation to common.PORT
A possibly-buggy fixture server uses `common.PORT+1000` for its port rather than `common.PORT`. That could result in it clashing with other ports if tests are run in parallel. The test runner increments `common.PORT` by 100 for each running instance for tests. Change to use common.PORT and have the tests that use the fixture start with common.PORT+1 for anything they need. PR-URL: #6990 Refs: #6989 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
1 parent 1c65f1e commit cde3014
Copy full SHA for cde3014

File tree

Expand file treeCollapse file tree

3 files changed

+3
-3
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

3 files changed

+3
-3
lines changed
Open diff view settings
Collapse file

‎test/fixtures/clustered-server/app.js‎

Copy file name to clipboardExpand all lines: test/fixtures/clustered-server/app.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,5 +31,5 @@ if (cluster.isMaster) {
3131
}
3232
} else {
3333
var server = http.createServer(handleRequest);
34-
server.listen(common.PORT+1000);
34+
server.listen(common.PORT);
3535
}
Collapse file

‎test/parallel/test-debug-port-cluster.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-debug-port-cluster.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ const common = require('../common');
33
const assert = require('assert');
44
const spawn = require('child_process').spawn;
55

6-
const PORT_MIN = common.PORT;
6+
const PORT_MIN = common.PORT + 1; // The fixture uses common.PORT.
77
const PORT_MAX = PORT_MIN + 2;
88

99
const args = [
Collapse file

‎test/parallel/test-debug-signal-cluster.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-debug-signal-cluster.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ var common = require('../common');
33
var assert = require('assert');
44
var spawn = require('child_process').spawn;
55

6-
var port = common.PORT + 42;
6+
var port = common.PORT + 1; // The fixture uses common.PORT.
77
var args = ['--debug-port=' + port,
88
common.fixturesDir + '/clustered-server/app.js'];
99
var options = { stdio: ['inherit', 'inherit', 'pipe', 'ipc'] };

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.