Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit cdc33df

Browse filesBrowse files
mcollinatargos
authored andcommitted
http: implement capture rejections for 'request' event
PR-URL: #27867 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
1 parent fa544c8 commit cdc33df
Copy full SHA for cdc33df

File tree

Expand file treeCollapse file tree

2 files changed

+129
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+129
-0
lines changed
Open diff view settings
Collapse file

‎lib/_http_server.js‎

Copy file name to clipboardExpand all lines: lib/_http_server.js
+21Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ const {
2929
} = primordials;
3030

3131
const net = require('net');
32+
const EE = require('events');
3233
const assert = require('internal/assert');
3334
const {
3435
parsers,
@@ -358,6 +359,26 @@ Server.prototype.setTimeout = function setTimeout(msecs, callback) {
358359
return this;
359360
};
360361

362+
Server.prototype[EE.captureRejectionSymbol] = function(
363+
err, event, req, res) {
364+
365+
switch (event) {
366+
case 'request':
367+
if (!res.headersSent && !res.writableEnded) {
368+
// Don't leak headers.
369+
for (const name of res.getHeaderNames()) {
370+
res.removeHeader(name);
371+
}
372+
res.statusCode = 500;
373+
res.end(STATUS_CODES[500]);
374+
} else {
375+
res.destroy();
376+
}
377+
break;
378+
default:
379+
this.emit('error', err);
380+
}
381+
};
361382

362383
function connectionListener(socket) {
363384
defaultTriggerAsyncIdScope(
Collapse file
+108Lines changed: 108 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,108 @@
1+
'use strict';
2+
3+
const common = require('../common');
4+
const events = require('events');
5+
const { createServer, request } = require('http');
6+
const assert = require('assert');
7+
8+
events.captureRejections = true;
9+
10+
{
11+
const server = createServer(common.mustCall(async (req, res) => {
12+
// We will test that this header is cleaned up before forwarding.
13+
res.setHeader('content-type', 'application/json');
14+
throw new Error('kaboom');
15+
}));
16+
17+
server.listen(0, common.mustCall(() => {
18+
const req = request({
19+
method: 'GET',
20+
host: server.address().host,
21+
port: server.address().port
22+
});
23+
24+
req.end();
25+
26+
req.on('response', common.mustCall((res) => {
27+
assert.strictEqual(res.statusCode, 500);
28+
assert.strictEqual(res.headers.hasOwnProperty('content-type'), false);
29+
let data = '';
30+
res.setEncoding('utf8');
31+
res.on('data', common.mustCall((chunk) => {
32+
data += chunk;
33+
}));
34+
res.on('end', common.mustCall(() => {
35+
assert.strictEqual(data, 'Internal Server Error');
36+
server.close();
37+
}));
38+
}));
39+
}));
40+
}
41+
42+
{
43+
let resolve;
44+
const latch = new Promise((_resolve) => {
45+
resolve = _resolve;
46+
});
47+
const server = createServer(common.mustCall(async (req, res) => {
48+
server.close();
49+
50+
// We will test that this header is cleaned up before forwarding.
51+
res.setHeader('content-type', 'application/json');
52+
res.write('{');
53+
req.resume();
54+
55+
// Wait so the data is on the wire
56+
await latch;
57+
58+
throw new Error('kaboom');
59+
}));
60+
61+
server.listen(0, common.mustCall(() => {
62+
const req = request({
63+
method: 'GET',
64+
host: server.address().host,
65+
port: server.address().port
66+
});
67+
68+
req.end();
69+
70+
req.on('response', common.mustCall((res) => {
71+
assert.strictEqual(res.statusCode, 200);
72+
assert.strictEqual(res.headers['content-type'], 'application/json');
73+
resolve();
74+
75+
let data = '';
76+
res.setEncoding('utf8');
77+
res.on('data', common.mustCall((chunk) => {
78+
data += chunk;
79+
}));
80+
81+
req.on('close', common.mustCall(() => {
82+
assert.strictEqual(data, '{');
83+
}));
84+
}));
85+
}));
86+
}
87+
88+
{
89+
const server = createServer(common.mustCall(async (req, res) => {
90+
// We will test that this header is cleaned up before forwarding.
91+
res.writeHead(200);
92+
throw new Error('kaboom');
93+
}));
94+
95+
server.listen(0, common.mustCall(() => {
96+
const req = request({
97+
method: 'GET',
98+
host: server.address().host,
99+
port: server.address().port
100+
});
101+
102+
req.end();
103+
req.on('error', common.mustCall((err) => {
104+
assert.strictEqual(err.code, 'ECONNRESET');
105+
server.close();
106+
}));
107+
}));
108+
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.