Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit cda1da9

Browse filesBrowse files
TrottBethGriggs
authored andcommitted
doc: update "Testing and CI" in Collaborator Guide
Update "Testing and CI" in the Collaborator Guide. Remove redundant material. Shorten sentences. Remove incorrect material. (Specifically, we don't require test cases to be included in all pull requests that modify exectuable code. For example, if code is refactored, then passing existing tests is sufficient.) PR-URL: #24884 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
1 parent 2a11e6a commit cda1da9
Copy full SHA for cda1da9

File tree

Expand file treeCollapse file tree

1 file changed

+11
-14
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+11
-14
lines changed
Open diff view settings
Collapse file

‎COLLABORATOR_GUIDE.md‎

Copy file name to clipboardExpand all lines: COLLABORATOR_GUIDE.md
+11-14Lines changed: 11 additions & 14 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -174,20 +174,17 @@ the comment anyway to avoid any doubt.
174174

175175
### Testing and CI
176176

177-
All bugfixes require a test case which demonstrates the defect. The
178-
test should *fail* before the change, and *pass* after the change.
179-
180-
All pull requests that modify executable code should also include a test case
181-
and must be subjected to continuous integration tests on the
182-
[project CI server](https://ci.nodejs.org/). The pull request should have a CI
183-
status indicator.
184-
185-
Do not land any Pull Requests without passing (green or yellow) CI runs. If you
186-
believe any failed (red or grey) CI sub-tasks are unrelated to the change in the
187-
Pull Request, use "Resume Build" in the left navigation of the relevant
188-
`node-test-pull-request` job. It will create a new `node-test-pull-request` run
189-
that preserves all the green results from the current job but re-runs everything
190-
else.
177+
All fixes must have a test case which demonstrates the defect. The test should
178+
fail before the change, and pass after the change.
179+
180+
All pull requests must pass continuous integration tests on the
181+
[project CI server](https://ci.nodejs.org/).
182+
183+
Do not land any Pull Requests without passing (green or yellow) CI runs. If
184+
there are CI failures unrelated to the change in the Pull Request, try "Resume
185+
Build". It is in the left navigation of the relevant `node-test-pull-request`
186+
job. It will preserve all the green results from the current job but re-run
187+
everything else.
191188

192189
#### Useful CI Jobs
193190

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.