Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit ccf90b6

Browse filesBrowse files
TrottMyles Borins
authored andcommitted
test: fix test-dns.js flakiness
Use empty string instead of `www.google.com` for tests where we are just doing parameter evaluation. This will avoid DNS lookups which appear to be causing flakiness on Raspberry Pi devices in CI. PR-URL: #5996 Fixes: #5554 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent 6f0bd64 commit ccf90b6
Copy full SHA for ccf90b6

File tree

Expand file treeCollapse file tree

1 file changed

+6
-6
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+6
-6
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-dns.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-dns.js
+6-6Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
'use strict';
22
require('../common');
3-
var assert = require('assert');
3+
const assert = require('assert');
44

5-
var dns = require('dns');
5+
const dns = require('dns');
66

77
var existing = dns.getServers();
88
assert(existing.length);
@@ -121,27 +121,27 @@ assert.doesNotThrow(function() {
121121
});
122122

123123
assert.doesNotThrow(function() {
124-
dns.lookup('www.google.com', {
124+
dns.lookup('', {
125125
family: 4,
126126
hints: 0
127127
}, noop);
128128
});
129129

130130
assert.doesNotThrow(function() {
131-
dns.lookup('www.google.com', {
131+
dns.lookup('', {
132132
family: 6,
133133
hints: dns.ADDRCONFIG
134134
}, noop);
135135
});
136136

137137
assert.doesNotThrow(function() {
138-
dns.lookup('www.google.com', {
138+
dns.lookup('', {
139139
hints: dns.V4MAPPED
140140
}, noop);
141141
});
142142

143143
assert.doesNotThrow(function() {
144-
dns.lookup('www.google.com', {
144+
dns.lookup('', {
145145
hints: dns.ADDRCONFIG | dns.V4MAPPED
146146
}, noop);
147147
});

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.