Commit ccf1178
committed
deps: V8: cherry-pick d3a1a5b6c491
Original commit message:
[objects] Fix memory leak in PrototypeUsers::Add
PrototypeUsers::Add now iterates the WeakArrayList to find empty slots
before growing the array. Not reusing empty slots caused a memory leak.
It might also be desirable to shrink the WeakArrayList in the future.
Right now it is only compacted when invoking CreateBlob.
Also removed unused PrototypeUsers::IsEmptySlot declaration.
Bug: v8:10031
Change-Id: I570ec78fca37e8f0c794f1f40846a4daab47c225
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1967317
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65456}
Refs: v8/v8@d3a1a5b
Fixes: #30753
PR-URL: #31005
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>1 parent 9d2e8c5 commit ccf1178Copy full SHA for ccf1178
File tree
Expand file treeCollapse file tree
3 files changed
+18
-2
lines changedOpen diff view settings
Filter options
- deps/v8/src/objects
Expand file treeCollapse file tree
3 files changed
+18
-2
lines changedOpen diff view settings
Collapse file
+1-1Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
38 | 38 | |
39 | 39 | |
40 | 40 | |
41 | | - |
| 41 | + |
42 | 42 | |
43 | 43 | |
44 | 44 | |
|
Collapse file
deps/v8/src/objects/objects.cc
Copy file name to clipboardExpand all lines: deps/v8/src/objects/objects.cc+16Lines changed: 16 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
4025 | 4025 | |
4026 | 4026 | |
4027 | 4027 | |
| 4028 | + |
| 4029 | + |
| 4030 | + |
| 4031 | + |
| 4032 | + |
| 4033 | + |
| 4034 | + |
4028 | 4035 | |
4029 | 4036 | |
4030 | 4037 | |
| ||
4047 | 4054 | |
4048 | 4055 | |
4049 | 4056 | |
| 4057 | + |
| 4058 | + |
| 4059 | + |
| 4060 | + |
| 4061 | + |
| 4062 | + |
| 4063 | + |
| 4064 | + |
| 4065 | + |
4050 | 4066 | |
4051 | 4067 | |
4052 | 4068 | |
|
Collapse file
deps/v8/src/objects/prototype-info.h
Copy file name to clipboardExpand all lines: deps/v8/src/objects/prototype-info.h+1-1Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
99 | 99 | |
100 | 100 | |
101 | 101 | |
102 | | - |
| 102 | + |
103 | 103 | |
104 | 104 | |
105 | 105 | |
|
0 commit comments