Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit cccf5a6

Browse filesBrowse files
sam-githubMylesBorins
authored andcommitted
src: --abort-on-uncaught-exception in NODE_OPTIONS
Allow --abort-on-uncaught-exception in NODE_OPTIONS, its useful to enable for post-mortem debugging. Backport-PR-URL: #12677 PR-URL: #13932 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent dd946c3 commit cccf5a6
Copy full SHA for cccf5a6

File tree

Expand file treeCollapse file tree

3 files changed

+5
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

3 files changed

+5
-2
lines changed
Open diff view settings
Collapse file

‎doc/api/cli.md‎

Copy file name to clipboardExpand all lines: doc/api/cli.md
+1Lines changed: 1 addition & 0 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -367,6 +367,7 @@ Node options that are allowed are:
367367
- `--zero-fill-buffers`
368368

369369
V8 options that are allowed are:
370+
- `--abort-on-uncaught-exception`
370371
- `--max_old_space_size`
371372

372373

Collapse file

‎src/node.cc‎

Copy file name to clipboardExpand all lines: src/node.cc
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3811,6 +3811,7 @@ static void CheckIfAllowedInEnv(const char* exe, bool is_env,
38113811
"--icu-data-dir",
38123812

38133813
// V8 options
3814+
"--abort-on-uncaught-exception",
38143815
"--max_old_space_size",
38153816
};
38163817

Collapse file

‎test/parallel/test-cli-node-options.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-cli-node-options.js
+3-2Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,8 @@ function disallow(opt) {
4141

4242
const printA = require.resolve('../fixtures/printA.js');
4343

44-
expect('-r ' + printA, 'A\nB\n');
44+
expect(`-r ${printA}`, 'A\nB\n');
45+
expect('--abort-on-uncaught-exception', 'B\n');
4546
expect('--no-deprecation', 'B\n');
4647
expect('--no-warnings', 'B\n');
4748
expect('--trace-warnings', 'B\n');
@@ -58,7 +59,7 @@ if (common.hasCrypto) {
5859
}
5960
expect('--icu-data-dir=_d', 'B\n');
6061

61-
// V8 options
62+
// V8 options
6263
expect('--max_old_space_size=0', 'B\n');
6364

6465
function expect(opt, want) {

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.