Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit cc744b9

Browse filesBrowse files
davidbenevanlucas
authored andcommitted
crypto: remove unnecessary SSLerr calls
These are OpenSSL-internal APIs that are no longer accessible in 1.1.0 and weren't necessary. OpenSSL will push its own errors and, if it doesn't, the calling code would handle it anyway. PR-URL: #16130 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rod Vagg <rod@vagg.org>
1 parent 201393f commit cc744b9
Copy full SHA for cc744b9

File tree

Expand file treeCollapse file tree

1 file changed

+0
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+0
-2
lines changed
Open diff view settings
Collapse file

‎src/node_crypto.cc‎

Copy file name to clipboardExpand all lines: src/node_crypto.cc
-2Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -668,7 +668,6 @@ int SSL_CTX_use_certificate_chain(SSL_CTX* ctx,
668668
x = PEM_read_bio_X509_AUX(in, nullptr, NoPasswordCallback, nullptr);
669669

670670
if (x == nullptr) {
671-
SSLerr(SSL_F_SSL_CTX_USE_CERTIFICATE_CHAIN_FILE, ERR_R_PEM_LIB);
672671
return 0;
673672
}
674673

@@ -679,7 +678,6 @@ int SSL_CTX_use_certificate_chain(SSL_CTX* ctx,
679678
// Read extra certs
680679
STACK_OF(X509)* extra_certs = sk_X509_new_null();
681680
if (extra_certs == nullptr) {
682-
SSLerr(SSL_F_SSL_CTX_USE_CERTIFICATE_CHAIN_FILE, ERR_R_MALLOC_FAILURE);
683681
goto done;
684682
}
685683

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.