Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit cc26431

Browse filesBrowse files
Trottaddaleax
authored andcommitted
test: fix flaky test-heapdump-http2
Replace stream.respondWithFile(__filename) with stream.respondWithFile(process.execPath). The test file is probably small enough on some operating systems to be sent immediately, without waiting for the receiving side to do anything. The fix was figured out by addaleax. Co-authored-by: Anna Henningsen <anna@addaleax.net> Ref: #34389 (comment) Fixes: #34389 PR-URL: #34415 Refs: #34389 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent e15dc5f commit cc26431
Copy full SHA for cc26431

File tree

Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Collapse file

‎test/pummel/test-heapdump-http2.js‎

Copy file name to clipboardExpand all lines: test/pummel/test-heapdump-http2.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ const http2 = require('http2');
1414

1515
const server = http2.createServer();
1616
server.on('stream', (stream) => {
17-
stream.respondWithFile(__filename);
17+
stream.respondWithFile(process.execPath);
1818
});
1919
server.listen(0, () => {
2020
const client = http2.connect(`http://localhost:${server.address().port}`);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.