Commit cbd3cf0
src: add debug CHECKs against empty handles
These checks were useful while investigating other issues;
using empty `Local<>`s can be very un-debuggable, because that
typically does not lead to assertions with debugging information
but rather crashes based on accessing invalid memory.
PR-URL: #26125
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent be671c3 commit cbd3cf0Copy full SHA for cbd3cf0
File tree
Expand file treeCollapse file tree
2 files changed
+6
-0
lines changedOpen diff view settings
Filter options
- src
- api
Expand file treeCollapse file tree
2 files changed
+6
-0
lines changedOpen diff view settings
Collapse file
+5Lines changed: 5 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
139 | 139 | |
140 | 140 | |
141 | 141 | |
| 142 | + |
| 143 | + |
| 144 | + |
| 145 | + |
| 146 | + |
142 | 147 | |
143 | 148 | |
144 | 149 | |
|
Collapse file
+1Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
710 | 710 | |
711 | 711 | |
712 | 712 | |
| 713 | + |
713 | 714 | |
714 | 715 | |
715 | 716 | |
|
0 commit comments