Commit cb0b53e
stream: lazy read ReadStream
Using stream._construct would cause the Readable
to incorrectly greedily start reading.
Fixes: #36251
PR-URL: #36823
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>1 parent 0c11a17 commit cb0b53eCopy full SHA for cb0b53e
File tree
Expand file treeCollapse file tree
3 files changed
+55
-1
lines changedOpen diff view settings
Filter options
- lib/internal/streams
- test/parallel
Expand file treeCollapse file tree
3 files changed
+55
-1
lines changedOpen diff view settings
Collapse file
lib/internal/streams/readable.js
Copy file name to clipboardExpand all lines: lib/internal/streams/readable.js+3-1Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
203 | 203 | |
204 | 204 | |
205 | 205 | |
206 | | - |
| 206 | + |
| 207 | + |
| 208 | + |
207 | 209 | |
208 | 210 | |
209 | 211 | |
|
Collapse file
test/parallel/test-stdin-from-file-spawn.js
Copy file name to clipboard+42Lines changed: 42 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
| 1 | + |
| 2 | + |
| 3 | + |
| 4 | + |
| 5 | + |
| 6 | + |
| 7 | + |
| 8 | + |
| 9 | + |
| 10 | + |
| 11 | + |
| 12 | + |
| 13 | + |
| 14 | + |
| 15 | + |
| 16 | + |
| 17 | + |
| 18 | + |
| 19 | + |
| 20 | + |
| 21 | + |
| 22 | + |
| 23 | + |
| 24 | + |
| 25 | + |
| 26 | + |
| 27 | + |
| 28 | + |
| 29 | + |
| 30 | + |
| 31 | + |
| 32 | + |
| 33 | + |
| 34 | + |
| 35 | + |
| 36 | + |
| 37 | + |
| 38 | + |
| 39 | + |
| 40 | + |
| 41 | + |
| 42 | + |
Collapse file
test/parallel/test-stream-construct.js
Copy file name to clipboardExpand all lines: test/parallel/test-stream-construct.js+10Lines changed: 10 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
268 | 268 | |
269 | 269 | |
270 | 270 | |
| 271 | + |
| 272 | + |
| 273 | + |
| 274 | + |
| 275 | + |
| 276 | + |
| 277 | + |
| 278 | + |
| 279 | + |
| 280 | + |
0 commit comments