Commit ca933ce
http2: do not falsely emit 'aborted' on push
A push stream should have its writable side closed upon receipt,
to avoid emitting the 'aborted' event when the readable side
is closed.
Backport-PR-URL: #22850
PR-URL: #22878
Fixes: #22851
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>1 parent 49f44f3 commit ca933ceCopy full SHA for ca933ce
File tree
Expand file treeCollapse file tree
2 files changed
+2
-0
lines changedOpen diff view settings
Filter options
- lib/internal/http2
- test/parallel
Expand file treeCollapse file tree
2 files changed
+2
-0
lines changedOpen diff view settings
Collapse file
+1Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
220 | 220 | |
221 | 221 | |
222 | 222 | |
| 223 | + |
223 | 224 | |
224 | 225 | |
225 | 226 | |
|
Collapse file
test/parallel/test-http2-server-push-stream.js
Copy file name to clipboardExpand all lines: test/parallel/test-http2-server-push-stream.js+1Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
54 | 54 | |
55 | 55 | |
56 | 56 | |
| 57 | + |
57 | 58 | |
58 | 59 | |
59 | 60 | |
|
0 commit comments