Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit ca8d4e3

Browse filesBrowse files
bnoordhuisBethGriggs
authored andcommitted
build: define NOMINMAX on windows
Build with `-DNOMINMAX` to stop `<windows.h>` from defining macros that conflict with `std::min()` and `std::max()`. Backport-PR-URL: #22731 PR-URL: #18216 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> PR-URL: #22731
1 parent 48f31bd commit ca8d4e3
Copy full SHA for ca8d4e3

File tree

Expand file treeCollapse file tree

1 file changed

+4
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+4
-0
lines changed
Open diff view settings
Collapse file

‎node.gyp‎

Copy file name to clipboardExpand all lines: node.gyp
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -446,6 +446,10 @@
446446
'FD_SETSIZE=1024',
447447
# we need to use node's preferred "win32" rather than gyp's preferred "win"
448448
'NODE_PLATFORM="win32"',
449+
# Stop <windows.h> from defining macros that conflict with
450+
# std::min() and std::max(). We don't use <windows.h> (much)
451+
# but we still inherit it from uv.h.
452+
'NOMINMAX',
449453
'_UNICODE=1',
450454
],
451455
'libraries': [ '-lpsapi.lib' ]

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.