Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit ca5607b

Browse filesBrowse files
sinkhahatargos
sinkhaha
authored and
targos
committed
events: update MaxListenersExceededWarning message log
PR-URL: #51921 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent fca38b2 commit ca5607b
Copy full SHA for ca5607b
Expand file treeCollapse file tree

6 files changed

+9
-6
lines changed
Open diff view settings
Collapse file

‎lib/events.js‎

Copy file name to clipboardExpand all lines: lib/events.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -593,7 +593,7 @@ function _addListener(target, type, listener, prepend) {
593593
// No error code for this since it is a Warning
594594
const w = genericNodeError(
595595
`Possible EventEmitter memory leak detected. ${existing.length} ${String(type)} listeners ` +
596-
`added to ${inspect(target, { depth: -1 })}. Use emitter.setMaxListeners() to increase limit`,
596+
`added to ${inspect(target, { depth: -1 })}. MaxListeners is ${m}. Use emitter.setMaxListeners() to increase limit`,
597597
{ name: 'MaxListenersExceededWarning', emitter: target, type: type, count: existing.length });
598598
process.emitWarning(w);
599599
}
Collapse file

‎lib/internal/event_target.js‎

Copy file name to clipboardExpand all lines: lib/internal/event_target.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -561,7 +561,7 @@ class EventTarget {
561561
// eslint-disable-next-line no-restricted-syntax
562562
const w = new Error('Possible EventTarget memory leak detected. ' +
563563
`${size} ${type} listeners ` +
564-
`added to ${inspect(this, { depth: -1 })}. Use ` +
564+
`added to ${inspect(this, { depth: -1 })}. MaxListeners is ${this[kMaxEventTargetListeners]}. Use ` +
565565
'events.setMaxListeners() to increase limit');
566566
w.name = 'MaxListenersExceededWarning';
567567
w.target = this;
Collapse file

‎test/parallel/test-event-emitter-max-listeners-warning-for-null.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-event-emitter-max-listeners-warning-for-null.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ process.on('warning', common.mustCall((warning) => {
1616
assert.strictEqual(warning.count, 2);
1717
assert.strictEqual(warning.type, null);
1818
assert.ok(warning.message.includes(
19-
'2 null listeners added to [EventEmitter].'));
19+
'2 null listeners added to [EventEmitter]. MaxListeners is 1.'));
2020
}));
2121

2222
e.on(null, () => {});
Collapse file

‎test/parallel/test-event-emitter-max-listeners-warning-for-symbol.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-event-emitter-max-listeners-warning-for-symbol.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ process.on('warning', common.mustCall((warning) => {
1818
assert.strictEqual(warning.count, 2);
1919
assert.strictEqual(warning.type, symbol);
2020
assert.ok(warning.message.includes(
21-
'2 Symbol(symbol) listeners added to [EventEmitter].'));
21+
'2 Symbol(symbol) listeners added to [EventEmitter]. MaxListeners is 1.'));
2222
}));
2323

2424
e.on(symbol, () => {});
Collapse file

‎test/parallel/test-event-emitter-max-listeners-warning.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-event-emitter-max-listeners-warning.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ process.on('warning', common.mustCall((warning) => {
2323
assert.strictEqual(warning.count, 2);
2424
assert.strictEqual(warning.type, 'event-type');
2525
assert.ok(warning.message.includes(
26-
'2 event-type listeners added to [FakeInput].'));
26+
'2 event-type listeners added to [FakeInput]. MaxListeners is 1.'));
2727
}));
2828

2929
e.on('event-type', () => {});
Collapse file

‎test/parallel/test-eventtarget-memoryleakwarning.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-eventtarget-memoryleakwarning.js
+4-1Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,18 +12,21 @@ const { setTimeout } = require('timers/promises');
1212
common.expectWarning({
1313
MaxListenersExceededWarning: [
1414
['Possible EventTarget memory leak detected. 3 foo listeners added to ' +
15-
'EventTarget. Use events.setMaxListeners() ' +
15+
'EventTarget. MaxListeners is 2. Use events.setMaxListeners() ' +
1616
'to increase limit'],
1717
['Possible EventTarget memory leak detected. 3 foo listeners added to ' +
1818
'[MessagePort [EventTarget]]. ' +
19+
'MaxListeners is 2. ' +
1920
'Use events.setMaxListeners() to increase ' +
2021
'limit'],
2122
['Possible EventTarget memory leak detected. 3 foo listeners added to ' +
2223
'[MessagePort [EventTarget]]. ' +
24+
'MaxListeners is 2. ' +
2325
'Use events.setMaxListeners() to increase ' +
2426
'limit'],
2527
['Possible EventTarget memory leak detected. 3 foo listeners added to ' +
2628
'[AbortSignal]. ' +
29+
'MaxListeners is 2. ' +
2730
'Use events.setMaxListeners() to increase ' +
2831
'limit'],
2932
],

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.