Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit ca27880

Browse filesBrowse files
jonask-wixMylesBorins
authored andcommitted
test: use default assertion message
In test-child-process-spawnsync, the assert.strictEqual() custom message was hiding information about why the test has failed. It just showed what value is expected and in case of failure we want to know which value has caused test to fail. PR-URL: #16819 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent fab5598 commit ca27880
Copy full SHA for ca27880

File tree

Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-child-process-spawnsync.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-child-process-spawnsync.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ const spawnSync = require('child_process').spawnSync;
2828
// Echo does different things on Windows and Unix, but in both cases, it does
2929
// more-or-less nothing if there are no parameters
3030
const ret = spawnSync('sleep', ['0']);
31-
assert.strictEqual(ret.status, 0, 'exit status should be zero');
31+
assert.strictEqual(ret.status, 0);
3232

3333
// Error test when command does not exist
3434
const ret_err = spawnSync('command_does_not_exist', ['bar']).error;

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.