Commit ca18525
test: improve performance of test-crypto-timing-safe-equal-benchmarks
Using `eval()` rather than `require()`'ing a fixture and deleting it
from the cache results in a roughtly 10x improvement in running time.
Fixes: #25984
Refs: #26229
PR-URL: #26237
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>1 parent 7e26ca6 commit ca18525Copy full SHA for ca18525
File tree
Expand file treeCollapse file tree
2 files changed
+15
-29
lines changedOpen diff view settings
Filter options
- test
- fixtures
- pummel
Expand file treeCollapse file tree
2 files changed
+15
-29
lines changedOpen diff view settings
Collapse file
test/fixtures/crypto-timing-safe-equal-benchmark-func.js
Copy file name to clipboardExpand all lines: test/fixtures/crypto-timing-safe-equal-benchmark-func.js-17Lines changed: 0 additions & 17 deletions
This file was deleted.
Collapse file
test/pummel/test-crypto-timing-safe-equal-benchmarks.js
Copy file name to clipboardExpand all lines: test/pummel/test-crypto-timing-safe-equal-benchmarks.js+15-12Lines changed: 15 additions & 12 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
6 | 6 | |
7 | 7 | |
8 | 8 | |
9 | | - |
10 | 9 | |
11 | 10 | |
12 | 11 | |
13 | | - |
14 | | - |
15 | | - |
16 | | - |
17 | | - |
18 | | - |
19 | | - |
20 | | - |
21 | | - |
22 | | - |
23 | | - |
| 12 | + |
| 13 | + |
| 14 | + |
| 15 | + |
| 16 | + |
| 17 | + |
| 18 | + |
| 19 | + |
| 20 | + |
| 21 | + |
| 22 | + |
| 23 | + |
| 24 | + |
| 25 | + |
| 26 | + |
24 | 27 | |
25 | 28 | |
26 | 29 | |
|
0 commit comments