Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit c91e31d

Browse filesBrowse files
ruyadornoaddaleax
authored andcommitted
doc: add author-ready label ref to onboarding doc
The "Labels" section of doc/guides/onboarding-extras.md was missing a reference to the `author-ready` label. This commit adds a description similar to the definition found in doc/guides/collaborator-guide.md with the goal of making it easier for new contributors to find labels info all in one place. PR-URL: #34381 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Myles Borins <myles.borins@gmail.com>
1 parent 319d570 commit c91e31d
Copy full SHA for c91e31d

File tree

Expand file treeCollapse file tree

1 file changed

+13
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+13
-1
lines changed
Open diff view settings
Collapse file

‎doc/guides/onboarding-extras.md‎

Copy file name to clipboardExpand all lines: doc/guides/onboarding-extras.md
+13-1Lines changed: 13 additions & 1 deletion
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,19 @@ request.
2424
* `tsc-agenda` - Open issues and pull requests with this label will be added to
2525
the Technical Steering Committee meeting agenda
2626

27-
--
27+
---
28+
29+
* `author-ready` - A pull request is _author ready_ when:
30+
* There is a CI run in progress or completed.
31+
* There is at least one Collaborator approval (or two TSC approvals
32+
for semver-major PRs).
33+
* There are no outstanding review comments.
34+
35+
Please always add the `author ready` label to the pull request in that case.
36+
Please always remove it again as soon as the conditions are not met anymore,
37+
such as if CI run fails or a new outstanding review comment is posted.
38+
39+
---
2840

2941
* `semver-{minor,major}`
3042
* be conservative – that is, if a change has the remote *chance* of breaking

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.